Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: build epics-base with GCC_PIPE=YES. #36

Closed
wants to merge 1 commit into from
Closed

base: build epics-base with GCC_PIPE=YES. #36

wants to merge 1 commit into from

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Nov 30, 2023

This can speed up the build by avoiding usage of temporary files.

This can speed up the build by avoiding usage of temporary files.
@ericonr
Copy link
Member Author

ericonr commented Nov 30, 2023

I'd say this doesn't need an entry in changes 🤔
What do you think?

@henriquesimoes
Copy link
Collaborator

Did you notice any significant difference locally? GitHub CI took barely the same time (a little bit worse, actually) for compiling EPICS base and modules.

Job EPICS base Modules Area Detector Motor
latest 232.2s 56.3s 110.1s 27.9s
PR #37 238.6s 66.4s* 115.2s 29.1s
This PR #36 244.3s 61.9s 117.5s 28.7s

*Unfair comparison since retools is also built.

I'd say this doesn't need an entry in changes 🤔

I agree. It shouldn't affect epics-in-docker users.

@ericonr
Copy link
Member Author

ericonr commented Dec 5, 2023

From looking around online, it doesn't help a whole lot, and can make memory consumption worse. Will close this

@ericonr ericonr closed this Dec 5, 2023
@ericonr ericonr deleted the pipe branch December 5, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants