-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
musl build #35
Merged
musl build #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, I think the issue was caused by some bad cache. I just got it to build without the workaround. |
ericonr
force-pushed
the
musl
branch
4 times, most recently
from
November 28, 2023 11:38
cd980ac
to
5bc536b
Compare
henriquesimoes
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is also missing in the README.md
and CHANGES.md
.
This is necessary for the asyn module with modern glibc or musl.
This is intended mainly for building fully static IOCs to be deployed on older machines. We are using Alpine since it's the main musl-based distro with LTS releases. We also document it in README and CHANGES.
It was also necessary to reorganize the env section for CI to work.
henriquesimoes
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't work yet, needs a patch, which is still under investigation. Considering simply forwarding this PR to tech-talk to see if we get any help.