Install tarball packages with custom extraction #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
requested changes
Sep 18, 2023
henriquesimoes
force-pushed
the
tar-packages
branch
2 times, most recently
from
7a44f81 to
9c39f4c
Compare
ericonr
reviewed
Sep 21, 2023
henriquesimoes
force-pushed
the
tar-packages
branch
from
9c39f4c to
2486789
Compare
ericonr
reviewed
Oct 13, 2023
henriquesimoes
force-pushed
the
tar-packages
branch
from
2486789 to
8f02abc
Compare
Trivial tarball extraction leads to file ownership to be kept, which can cause permission problems with rootless container engines. This could be overcome by changing subuid and subgid ranges or ignoring ownership from the container filesystem in the installed machine. However, this leads to a more difficult setup for the IOC machines. Instead, file ownership is ignored during extraction in the build phase. This requirement of customizing extraction for all downloaded archives justifies having a dedicated helper script for both downloading and extracting archives. For convenience, a list of URLs can be defined. Tarball archives are downloaded to a dedicated temporary directory to avoid filename conflicts, since they might have arbitrary names. The extraction can be made either in the current directory or at the filesystem root. The latter is useful to extract to specific directories without any intervention. It should be used, for instance, to install custom packages to the /usr/local tree. Noisy output from commands are replaced by short messages to make the build progress more clean. Exceptionally, `wget` output is logged to stdout only when it fails.
This makes it possible to install software not packaged in the distribution repositories, such as closed-source local packages. Packages can be installed during the build-stage, since the IOC might require a given library also at compile time. `ldconfig` is executed at the end to refresh the dynamic linker library resolution cache, which is required to identify new libraries installed with lnls-get-n-unpack. `ldconfig` is not required for the build stage, as dynamic link will take place only during the binary runtime.
ericonr
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing through tarballs is useful to enable us to include software that is not yet packaged in the distribution repositories.
A custom extraction script is interesting to solve, in a centralized way, permission issues in rootless container engines both for source code and binaries packages.
I've named the custom script
untar, but I'm open to suggestions for other names.