ioc: add stage without IOC building. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to run an IOC which was built along with its support module. This pattern is used for some community modules, including motor's and areaDetector's ones. A new (empty) stage has been created only to specify the base image in the COPY command, since `--from` argument does not support variable expansion [1]. `build-stage` has been moved below `no-build` stage, so bad multi-stage resolvers won't fail for the new stage. [1]: https://forums.docker.com/t/how-can-i-expand-a-variable-within-a-copy-command-in-the-dockerfile/113538/2
ericonr
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to run an IOC which was built along with its support module. This pattern is used for some community modules, including motor's and areaDetector's ones.
A new (empty) stage has been created only to specify the base image in the COPY command, since
--fromargument does not support variable expansion.build-stagehas been moved belowno-buildstage, so bad multi-stage resolvers won't fail for the new stage.