Allow empty type from openapi yaml (#420)

* Resolves #419
* apply fix in from yaml class instead
* conditionally set type on schema property from yaml
* cleans up structural error in paths: should NOT have additional properties additionalProperty: tags

src/Lib/OpenApi/Path.php

@@ -48,7 +48,7 @@ public function __construct(
     public function toArray(): array
     {
         $vars = get_object_vars($this);
-        $vars = ArrayUtility::removeKeysMatching($vars, ['resource', 'operations', 'ref']);
+        $vars = ArrayUtility::removeKeysMatching($vars, ['resource', 'operations', 'ref', 'tags']);
 
         // remove items if null to reduce JSON clutter
         $vars = ArrayUtility::removeNullValues($vars, ['summary', 'description']);

src/Lib/OpenApi/SchemaProperty.php

@@ -48,13 +48,15 @@ class SchemaProperty implements JsonSerializable, SchemaInterface
      */
     public function __construct(
         ?string $name = null,
-        string $type = 'string',
+        ?string $type = null,
         ?string $format = null,
         ?string $description = null,
         mixed $example = null,
     ) {
         $this->name = $name;
-        $this->setType($type);
+        if ($type !== null) {
+            $this->setType($type);
+        }
         $this->format = $format;
         $this->description = $description;
         $this->example = $example;
@@ -91,7 +93,7 @@ public function toArray(): array
             [
                 'format','title','description','multipleOf','minimum','maximum','minLength','maxLength','pattern',
                 'minItems','maxItems','minProperties','maxProperties','items','enum','default','exclusiveMinimum',
-                'exclusiveMaximum','uniqueItems','nullable',
+                'exclusiveMaximum','uniqueItems','nullable','type',
             ]
         );
 

src/Lib/OpenApi/SchemaTrait.php

@@ -30,7 +30,8 @@ public function setType(string $type)
     {
         if (!in_array($type, OpenApiDataType::TYPES)) {
             throw new InvalidArgumentException(
-                "Type $type is not valid. Must be one of " . implode(',', OpenApiDataType::TYPES)
+                "Schema type of `$type` is invalid. Must be one of: " .
+                implode(',', OpenApiDataType::TYPES)
             );
         }
 

src/Lib/Schema/SchemaPropertyFromYamlFactory.php

@@ -24,17 +24,17 @@ public function create(string $name, array $yaml): SchemaProperty
         $schemaProperty = (new SchemaProperty())
             ->setName($name)
             ->setDescription($yaml['description'] ?? '')
-            ->setType($yaml['type'] ?? '')
             ->setReadOnly($yaml['readonly'] ?? false)
             ->setWriteOnly($yaml['writeOnly'] ?? false)
             ->setRequired($yaml['required'] ?? false)
             ->setEnum($yaml['enum'] ?? [])
-            ->setExample($yaml['example'] ?? '')
+            ->setExample($yaml['example'] ?? null)
             ->setItems($yaml['items'] ?? [])
             ->setRefEntity($yaml['$ref'] ?? '')
             ->setFormat($yaml['format'] ?? '');
 
         $properties = [
+            'type',
             'maxLength',
             'minLength',
             'pattern',

tests/test_app/config/swagger-with-existing.yml

@@ -164,5 +164,24 @@ components:
           example: error message here
       xml:
         name: response
+# issue: https://github.com/cnizzardini/cakephp-swagger-bake/issues/419
+    Address:
+      type: object
+      properties:
+        city:
+          type: string
+          example: "Brazzaville"
+        zone:
+          type: string
+          example: "Zone 1"
+    User:
+      type: object
+      properties:
+        name:
+          type: string
+          example: "De claude"
+        address:
+          $ref: '#/components/schemas/Address'
+# end issue
 security:
   - BearerAuth: []