Log error getting annotations in genie-controller.go #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stevo Slavić <[email protected]>
|
@m1093782566 @sushanthakumar @kevin-wangzefeng @vinaykul can you please take a look? |
sushanthakumar
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting pod annotations for CNI, Genie controller would swallow underlying error in case of
len(k8sArgs.K8S_ANNOT) == 0which can happen for many reasons.In an incident, all new Pods were failing to be created, genie was erroring
CNI Genie Add IP internal error: Error getting annotations for pod (foo:bar): No pod or env var found, result: %!!(MISSING)s(<nil>)Missing underlying error made debugging hard.
This PR:
getK8sPodAnnotationscall