Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd to gha-runner-image #17

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add zstd to gha-runner-image #17

merged 1 commit into from
Oct 25, 2024

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Oct 24, 2024

zstd provides fast and good compression. It's available in default GitHub runners, but not in the hosted runners.

zstd provides fast and good compression

Signed-off-by: Stian Thorgersen <[email protected]>
@RobertKielty
Copy link
Contributor

@stianst thank you for submitting this pull request.

@jeefy did some investigation as to why the provenance/verify failed on the PR. I have some leads but I couldn't get this working just yet.

https://github.com/slsa-framework/slsa-github-generator/issues?q=is%3Aissue++exit+27+

@RobertKielty RobertKielty merged commit fa82c5d into cncf:main Oct 25, 2024
4 of 7 checks passed
@RobertKielty
Copy link
Contributor

RobertKielty commented Oct 25, 2024

@jeefy looks like the salsa workflow steps do not work on the PR run but run fine when merged to main. (permissions maybe?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants