Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3WE Rank Rework #7733

Merged
merged 21 commits into from
Dec 11, 2024
Merged

3WE Rank Rework #7733

merged 21 commits into from
Dec 11, 2024

Conversation

IroquoisLou
Copy link
Contributor

@IroquoisLou IroquoisLou commented Dec 4, 2024

About the pull request

Removes the japanese names from the 3WE ranks, adds the new rank of colour sergeant to the RMC.

Explain why it's good for the game

Consistency, the RMC officer ranks don't have japanese hybrid names so the enlisted shouldn't either, as for the colour sergeant rank it's to expand on the RMC ranking system, as currently they don't have an equivalent to staff sergeant, i've also changed all ranks to their IRL equivalent.

In addition, i've added IASF ranks for future use in IASF Erts, these use japanese navy ranks for officers and japanese army ranks for the enlisted.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

Removed Japanese title's from the RMC, instead RMC will use the Real RMC's ranks while japanese ranks go to the IASF.

🆑
add: Added the rank of colour sergeant to the RMC, to give the RMC, a Staff Sergeant equivalent
del: Removed the japanese title's from the RMC ranks
/:cl:

@cmss13-ci cmss13-ci bot added Feature Feature coder badge Removal snap labels Dec 4, 2024
@thevandie
Copy link
Contributor

Wait, can you please re add the Japanese ranks but comment them out? I plan to use those titles for the IASF later, so having all the names on hand would be useful later incase I forget

@efzapa
Copy link
Contributor

efzapa commented Dec 4, 2024

should probably get lore approval tbh, considering 3WE includes Great Britain and Japan, removing them (Japan) almost entirely from the game apart from the "Emperor" rank is odd to say the least.

@cuberound
Copy link
Contributor

the correct reasoning is not "officers do not have it so standard should not either" but "standards have them and they are the only roles that apper in gameplay, officers should have them too" at least in my opinion

@Lukas-Seltz
Copy link
Contributor

If I remember correctly Japan is the primary faction of the TWE and should follow Japanese rank system. As well as TWE is missing many officer ranks as they follow naval.

@IroquoisLou
Copy link
Contributor Author

IroquoisLou commented Dec 4, 2024

should probably get lore approval tbh, considering 3WE includes Great Britain and Japan, removing them (Japan) almost entirely from the game apart from the "Emperor" rank is odd to say the least.

3WE also includes india but we don't have indian ranks, the UPP includes Germany and Spain as founding countries along with china but i only see russian ranks, factions usually take the ranks of the predominant force, only the 3WE is stuck with this weird rank system, the UPP isn't.

As for why i'm keeping the emperor rank: it's an event only rank and is more of an aristocratic title then any real ranking.

the correct reasoning is not "officers do not have it so standard should not either" but "standards have them and they are the only roles that apper in gameplay, officers should have them too" at least in my opinion

Officers in lore are only the british ranks, this is because the RMC is based off the british Royal Marines, the only japanese ranks should be in the IASF, which is the more japanese focused part of the 3WE military.

If I remember correctly Japan is the primary faction of the TWE and should follow Japanese rank system. As well as TWE is missing many officer ranks as they follow naval.

No it isn't, the 3WE was formed by japan and britain (along with the commonwealth) merging, neither is really above the other, but the 3WE mainly takes from britain, their flag is more union jack inspired then inspired by the japanese flag, they have a parliament and a prime minister like the UK, so if anything the 3WE is more british.

Wait, can you please re add the Japanese ranks but comment them out? I plan to use those titles for the IASF later, so having all the names on hand would be useful later incase I forget

No because the RMC ranks don't even fully conform with japanese ranks.

@efzapa
Copy link
Contributor

efzapa commented Dec 4, 2024

should probably get lore approval tbh, considering 3WE includes Great Britain and Japan, removing them (Japan) almost entirely from the game apart from the "Emperor" rank is odd to say the least.

3WE also includes india but we don't have indian ranks, the UPP includes Germany and Spain as founding countries along with china but i only see russian ranks, factions usually take the ranks of the predominant force, only the 3WE is stuck with this weird rank system, the UPP isn't.

3WE was formed from Great Britian and Japan, the rest are simply allies that were merged in and would not have the bargaining power to have a say in the military as much as the main two.

Same could be said for the UPP, where it can be assumed both Russia is vastly larger AND most of the military would be Russian

@IroquoisLou
Copy link
Contributor Author

IroquoisLou commented Dec 4, 2024

should probably get lore approval tbh, considering 3WE includes Great Britain and Japan, removing them (Japan) almost entirely from the game apart from the "Emperor" rank is odd to say the least.

3WE also includes india but we don't have indian ranks, the UPP includes Germany and Spain as founding countries along with china but i only see russian ranks, factions usually take the ranks of the predominant force, only the 3WE is stuck with this weird rank system, the UPP isn't.

3WE was formed from Great Britian and Japan, the rest are simply allies that were merged in and would not have the bargaining power to have a say in the military as much as the main two.

Same could be said for the UPP, where it can be assumed both Russia is vastly larger AND most of the military would be Russian

And Britain's military is bigger then Japan's (which only has a self defense force), oh and also china has more people in it's military and is just as large, if not larger, then russia, so i guess we should change UPP's ranks to chinese right?

oh and also spain and germany should have just as much bargaining power as the UPP in that case given they're literal founders of it.

@cuberound
Copy link
Contributor

cuberound commented Dec 5, 2024

should probably get lore approval tbh, considering 3WE includes Great Britain and Japan, removing them (Japan) almost entirely from the game apart from the "Emperor" rank is odd to say the least.

3WE also includes india but we don't have indian ranks, the UPP includes Germany and Spain as founding countries along with china but i only see russian ranks, factions usually take the ranks of the predominant force, only the 3WE is stuck with this weird rank system, the UPP isn't.

3WE was formed from Great Britian and Japan, the rest are simply allies that were merged in and would not have the bargaining power to have a say in the military as much as the main two.
Same could be said for the UPP, where it can be assumed both Russia is vastly larger AND most of the military would be Russian

And Britain's military is bigger then Japan's (which only has a self defense force), oh and also china has more people in it's military and is just as large, if not larger, then russia, so i guess we should change UPP's ranks to chinese right?

oh and also spain and germany should have just as much bargaining power as the UPP in that case given they're literal founders of it.

oh and they do use names from other faction, UPP ship has german name and guns technicly use "type" stuff generly used for chinese designs. the reason why UPP have russian ranks is that someone bothered to change them form the english ranks thay had to the only rank system of UPP that they knew. UPP uses names from other factions too where it is possible, you do not even bother and make a step away from the correct path. the reason why UPP do not have more chinese stuff is the firewall and that we have super few players from china.

@IroquoisLou
Copy link
Contributor Author

IroquoisLou commented Dec 5, 2024

should probably get lore approval tbh, considering 3WE includes Great Britain and Japan, removing them (Japan) almost entirely from the game apart from the "Emperor" rank is odd to say the least.

3WE also includes india but we don't have indian ranks, the UPP includes Germany and Spain as founding countries along with china but i only see russian ranks, factions usually take the ranks of the predominant force, only the 3WE is stuck with this weird rank system, the UPP isn't.

3WE was formed from Great Britian and Japan, the rest are simply allies that were merged in and would not have the bargaining power to have a say in the military as much as the main two.
Same could be said for the UPP, where it can be assumed both Russia is vastly larger AND most of the military would be Russian

And Britain's military is bigger then Japan's (which only has a self defense force), oh and also china has more people in it's military and is just as large, if not larger, then russia, so i guess we should change UPP's ranks to chinese right?
oh and also spain and germany should have just as much bargaining power as the UPP in that case given they're literal founders of it.

oh and they do use names from other faction, UPP ship has german name and guns technicly use "type" stuff generly used for chinese designs. the reason why UPP have russian ranks is that someone bothered to change them form the english ranks thay had to the only rank system of UPP that they knew. UPP uses names from other factions too where it is possible, you do not even bother and make a step away from the correct path. the reason why UPP do not have more chinese stuff is the firewall and that we have super few players from china.

Yes and the 3WE does use Japanese names and indian names when possible, but they don't have hybrid ranks, anyways here's confirmation off Kaga on the RMC ranks,

Once thevandie gets his IASF in i'll make sure they get japanese ranks (and i mean proper japanese ranks not japanese word in front of a rank) but the RMC will be RMC ranks.

image

@IroquoisLou
Copy link
Contributor Author

IroquoisLou commented Dec 5, 2024

Alright, i'm expanding this even further, i'm changing the RMC's officers ranks to be more accurate to the real RMC, while also adding in Japanese ranks for the IASF.

The plan for the IASF is for them to have ground self defence force for enlisted and naval self defence force ranks with officers, this way if you want Japanese ranks you can add in other IASF roles that uses it (besides vandu's IASF Nightmare insert coming later.)

@IroquoisLou
Copy link
Contributor Author

I'll add descriptions to the IASF tomorrow

@harryob harryob added this pull request to the merge queue Dec 11, 2024
Merged via the queue into cmss13-devs:master with commit 10f2f45 Dec 11, 2024
25 checks passed
cmss13-ci bot added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants