Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praetorian Dancer Dodge now creates Afterimage(s). #7714

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Dec 1, 2024

About the pull request

Add "afterimage" effect to Dancer "Dodge" skill

Make sure to TMs it first, i was testing it alone, and i have suspicion that it will break something

Explain why it's good for the game

Add Afterimage effect to Dancer prae Dodge, it lack any indication that it uses "Dodge", this PR is to give prae dancer visual indication of dodge ability, and make them look like they are "Hard to Shoot".

(this is intended to be only visuals)

Demonstration Video:

Click HERE to see Video

Final Version:

2024-12-02.13-32-55.mp4

Changelog

🆑 Venuska1117
balance: Add "Afterimage" effect to Dancer Praetorian "Dodge" ability.
/:cl:

@cmss13-ci cmss13-ci bot added the Code Improvement Make the code longer label Dec 1, 2024
@Venuska1117 Venuska1117 changed the title Praetorian Dancer Dodge now creates After-Images. Praetorian Dancer Dodge now creates Afterimage(s). Dec 1, 2024
@Diegoflores31
Copy link
Contributor

please add a video of the prae using this ability while being shot by a sentry

@Venuska1117
Copy link
Contributor Author

please add a video of the prae using this ability while being shot by a sentry

Added

@Zenith00000
Copy link
Contributor

Perhaps make the effect cut off sooner, it lasts too long. Also perhaps make it have less opacity as well, I can see this being a bit confusing for marines in the dark with the long lingering after-image. Either way looks good, I like it.

@Venuska1117
Copy link
Contributor Author

Perhaps make the effect cut off sooner, it lasts too long. Also perhaps make it have less opacity as well, I can see this being a bit confusing for marines in the dark with the long lingering after-image. Either way looks good, I like it.

this effect last the same duration of dodge ability, but opacity can be changed.

@Venuska1117 Venuska1117 marked this pull request as draft December 1, 2024 22:04
@Red-byte3D
Copy link
Contributor

feature tag

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 1, 2024
@TheManWithNoHands
Copy link
Contributor

this effect last the same duration of dodge ability, but opacity can be changed.

More the duration the after images are visible before they are completly faded.
Imagine a dancer going quickly in circels, and you have a hard time seeing what an after image is and what not.
Just try to shorten the time the afterimages are visible. Or their "lifetime" so to speak.

Would be a cool ability to creat after images to confuse marines. But that be a completly diffrent ability. One i kinda want now.

@Venuska1117
Copy link
Contributor Author

this effect last the same duration of dodge ability, but opacity can be changed.

More the duration the after images are visible before they are completly faded. Imagine a dancer going quickly in circels, and you have a hard time seeing what an after image is and what not. Just try to shorten the time the afterimages are visible. Or their "lifetime" so to speak.

Would be a cool ability to creat after images to confuse marines. But that be a completly diffrent ability. One i kinda want now.

Isnt that, what dance supposed to do?

@TheManWithNoHands
Copy link
Contributor

TheManWithNoHands commented Dec 1, 2024

Isnt that, what dance supposed to do?

I mean yeah. But the VFX is just supposed to be a visual indicator and not the actual part of the ability that make em hard to hit. Rigth?
Nothing against that, that could absolutly work. But then i say lean into it.

@Venuska1117
Copy link
Contributor Author

Isnt that, what dance supposed to do?

I mean yeah. But the VFX is just supposed to be a visual indicator and not the actual part of the ability that make em hard to hit. Rigth?

its visual effect, yeah, i fixed mouse opacity issue so you CANNOT target afterimages, they are visuals made to confuse marines, not to avoid damage or take bullets.

- Added offset to movement, so it look like dancer is "dancing".
- Fixed Afterimage layering issue.
- Changed afterimages mouse_opacity to 0, so they cannot be pressed on with mouse/examined

I made some other changes, like adding offset to direction and such, small details.
@Venuska1117 Venuska1117 marked this pull request as ready for review December 1, 2024 23:07
Venuska1117 added 3 commits December 2, 2024 00:09
- Added name for dancer afterimage, in case players will be "somehow" able to see it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants