Helmet garb fix (lingering squad stripe) #7713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow up to #5573 which increased the amount of inventory slots in helmets, which meant more overlays were possible. It also removes some dead code attempting to add a hugger damage overlay to a helmet when the icon_state doesn't exist anywhere in cm and update_icons would just immediately clear the item from the helmet_overlays.
Explain why it's good for the game
Fixes #5912
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/PtsCM_MHHoA
Changelog
🆑 Drathek
fix: Fix squad overlay sometimes not getting removed when helmet exceeded its helmet garb overlay slots
del: Remove some effectively dead code attempting to add hugger damage to helmets
/:cl: