Missing icons unit test expansion #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es ignore list with c&d Initial fixes (icons & hard refs) Refactor giant lizards to use weakrefs
cmss13-ci
bot
added
Sprites
Blundir
approved these changes
Nov 26, 2024
set various kit box overlays to ones that exist
harryob
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is an experimental change to the missing icons unit test where it now instantiates all items to check their items (meaning they will do whatever they do to their icon_state in Initialize). This ended up causing several new hard deletes that I had to fix too. The create and destroy unit test shares exclusions now with missing icons. I originally started this because #7021 is likely going to need help sorting out lots of missing icons at runtime that weren't caught with the old unit test.
No actual pixel changes in sprites: Just renames, removals, or addition of blank states.Added unlocked overlay to
/obj/item/storage/backpack/satchel/lockableRestored the spike overlays to
/obj/item/weapon/gun/launcher/spikeremoved some reason in #7361Tweaked transparency and edges on old alien samples:
Currently there are 847 warnings for missing mob icons (could be more if blanket testing slots that allow equipping the item), but these are only mentioned in the warnings section (nor annotated currently though I would like warnings to eventually be annotated once there isn't so much noise).
Explain why it's good for the game
More robust testing for hard deletes and missing icons.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/uB8Z4yNjfDA
Changelog
🆑 Drathek
code: Missing Icons unit test now instantiates items and generally tests more icon_states
code: Unit tests can now log warnings that appear as a separate collapsed list but do not fail checks
fix: Fixed various hardrefs and missing icons
fix: Pipes retain their dir when picked up, no longer go invisible when re-anchored, and reconnect when re-anchored.
fix: Disabled various admin only pistols from being equipped in pistol belts since they only honk their underlay
refactor: Giant lizards and parent types now use weakrefs
refactor: Removed has_gamemode_skin and renamed NO_SNOW_TYPE to NO_GAMEMODE_SKIN
refactor: Removed uses_skin_color in favor of the existing flag HAS_SKIN_COLOR
maptweak: Fixed droppod floors on trijent elevator, lifeboats, corsat, and bigred
imageadd: Added missing unlocked overlay to lockable satchel
imageadd: Restored the missing overlays to spike launcher
imageadd: Tweaked the old sample jars and samples
admin: Admin spawned predators now have random skin color
/:cl: