Reaction fixes, refactoring, and flash powder retune #7654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad (still only used by any reaction) Remove required other reaction parameter Autodoc comments
…, cannot react in mobs, causes logging, and has 3 different ramping values for duration, range, and power
Drulikar
added
the
Balance Approved
cmss13-ci
bot
added
Balance
Co-authored-by: harryob <[email protected]>
harryob
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR refactors a bit of chemistry code (var cleanup, removal of required_other, rework required_container to do path checking), disables mob reaction for several reactions, and retunes the flash power effect.
Flash powder now creates a chemical light in the contents of its reagent holder (allowing it to be destroyed), has some additional logging, and has had its duration, range, and power retuned:
Explain why it's good for the game
This hopefully gives a bit of experimentation to using this reaction, tones down how excessive it can be, and introduces a bit of counterplay now that it is now destroyable.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/HSCVT3V1saQ
Changelog
🆑 Drathek
balance: emp_pulse, flash_powder, and foam reactions are no longer possible in mobs
balance: flash_powder has been reworked to attach to its holder (so it can be destroyed), and values retuned/capped.
refactor: Refactored the metabolize proc for chemistry reactors (removed required_other and changed required_container to use a path check instead)
/:cl: