adds poll subsystem, entities and ui #7645
Open
+517
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
reviewed
Dec 14, 2024
| /datum/controller/subsystem/polls/proc/handle_new_user(source, client/new_client) | ||
| SIGNAL_HANDLER | ||
|
|
||
| INVOKE_ASYNC(src, PROC_REF(remind_new_user), new_client) |
There was a problem hiding this comment.
I don't think you need to INVOKE_ASYNC since it's waitfor = FALSE anyway
Comment on lines
+109
to
+110
| while(!new_client.player_data) | ||
| stoplag() |
There was a problem hiding this comment.
UNTIL(new_client.player_data)
but honestly it could be useful to just strap signaling in load_player_data_info
Comment on lines
-22
to
-23
| UnregisterSignal(owner.mob, list(COMSIG_MOVABLE_MOVED, COMSIG_MOB_LOGOUT)) | ||
| UnregisterSignal(owner, COMSIG_CLIENT_MOB_LOGGED_IN) |
There was a problem hiding this comment.
Doesn't look related to me, is it a mistake?
There was a problem hiding this comment.
it runtimed often and annoyed me :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polls and stuff
in order to most effectively ignore player feedback, we need to know what players want more
🆑
add: added a poll button to the lobby screen. engage democratically.
/:cl: