Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code bounty] Yautja Hunting Bow #7492

Draft
wants to merge 61 commits into
base: master
Choose a base branch
from

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Nov 4, 2024

About the pull request

Design doc: https://docs.google.com/document/d/1MaMh5aBPh8d8v-qnHQBZf3iv9qrfyg8RnjJ8FNVJaPs/edit?tab=t.0

Adds a bow, a quiver and arrows, and icons for everything.

Only yautja can use the bow. The weapon is designed to be used against dishonorable prey. Arrows have two modes: standard and activated. The standard arrow acts like an arrow, it simply deals damage on impact and gets stuck in the body (you can pull it out of the body later, if it's a human). If you miss, the arrow remains on the ground. The activated arrow explodes on impact, which is similar to lethal HPC, cannot be recovered. The arrow can fall out of the bow if you drop the bow or try to return the bow to the strap, which means you can not store a loaded bow on the strap. The quiver strap holds a bow and 7 arrows, it can be worn on the belt and in the suit storage slots.

I also changed "yank out" verb slightly for it to make a bit more sense.

All credits to @thwompa

Explain why it's good for the game

More options for yautja. Cool sprites. Interesting mechanics.

Testing Photographs and Procedure

bow.mp4
bow2.mp4

Changelog

🆑 Thwomper, ihatethisengine
add: introduced hunting bow as a secondary weapon for yautja.
/:cl:

@cmss13-ci cmss13-ci bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Nov 4, 2024
@irakligabunia
Copy link
Contributor

how do u get more arrows

@vero5123
Copy link
Contributor

vero5123 commented Nov 4, 2024

i'll review this pr so I can get nepo points for my Yautja application.

code/datums/ammo/misc.dm Outdated Show resolved Hide resolved
code/datums/ammo/misc.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_weapons.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_weapons.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_weapons.dm Outdated Show resolved Hide resolved
@vero5123
Copy link
Contributor

vero5123 commented Nov 4, 2024

gimme a +1 on my upcoming pred app, ;P

@vero5123
Copy link
Contributor

vero5123 commented Nov 4, 2024

I think it would make sense if it required both hands on the bow to actually shoot the arrow. One shouldn't be able to shoot the arrow and have a melee weapon in another hand at the same time. Just my opinion.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 7, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cmss13-ci cmss13-ci bot added Mapping did you remember to save in tgm format? UI deletes nanoui/html labels Nov 7, 2024
@ihatethisengine ihatethisengine marked this pull request as ready for review November 7, 2024 21:28
@ihatethisengine
Copy link
Contributor Author

I fucked up with conflict resolving, please remove mapping and ui tags

@Nanu308 Nanu308 removed Mapping did you remember to save in tgm format? UI deletes nanoui/html labels Nov 9, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 12, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 17, 2024
cm13-github added a commit that referenced this pull request Nov 21, 2024
@Wintermote
Copy link

Would be nice to have a draw mechanic to it - when ready to fire click and hold down and draw the bow. Let go to release the arrow.

Then you can let marines try to draw the bow but they are weak girly men and can't do it so well.

Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onmob holster sprites aren't coded in properly, thus being invisible in the game, also some problems with the sprites themselves, elaborated to Thwomp in discord

@Blundir Blundir marked this pull request as draft November 22, 2024 03:57
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 29, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Sound Blast 5 minutes of bass boosted music to our players Sprites Remove the soul from the game.
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

8 participants