Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LV-624 Corporate Dome Nightmare Insert Changes #7031

Closed
wants to merge 0 commits into from

Conversation

BOBAMAx
Copy link
Contributor

@BOBAMAx BOBAMAx commented Aug 25, 2024

About the pull request

This PR adds three new goon survivor roles and adds them to the corporate dome nightmare insert:
Medic, Engineer, and Team Lead.

Also, I added the original goon survivor to the weyland_survivor faction along with all the new goon survivor roles, as it never had it for some reason. This meant that all the nightmare roles excluding the CL himself would set off the WY motion detector included in the insert. Now none of them do, with the added side effect of being on the PMC IFF network now, just like the regular goon ERT.

There is now a spawner for:
1 CL
1 TL
1 Medic
1 Engineer
and a bunch of regular goons.

I tried to keep the equipment and skills they start with on par with regular survivor roles minus the engineer, who got the ERT fuel satchel to make him more visually distinct from a regular goon because folded welding goggles are basically invisible compared to a medhud. I'm not too concerned about the NSG the leader has because it's the stripped version with no underbarrel flamethrower and half the maps have NSG spawns that nobody uses anyway because the gun kinda sucks.

The goon leader has similar skills to the ERT version which includes engineering skills.

Spawn priority is:
CL = Medic > TL > Engineer > Standard Goons.

Explain why it's good for the game

The same rationale for why the solaris PMC insert and the CLF crashed ship insert got engineers, medics, and team leads: survivor gameplay without medics or engineers sucks. Getting IB is now no longer a guaranteed death sentence and the plasteel the nightmare insert includes can now actually be used by someone other than a synthetic survivor. The team lead isn't as important but having a distinct shotcaller is good for organization like with FORECON and the CLF insert. Also, he looks cool.

Testing Photographs and Procedure

nightmare

Tested by forcing the insert and manually spawning myself as all the new and edited roles with the player panel equipment menu. This is my first PR though so I could have messed something up.

Changelog

🆑 BOBAMA
add: Added Goon Survivor Engineers, Medics, and Team Leads and put them in the LV-624 Corporate Dome Nightmare Insert.
maptweak: slightly adjusted LV-624 Corporate Dome Nightmare Insert Survivor Spawns.
/:cl:

@BOBAMAx BOBAMAx requested a review from Nanu308 as a code owner August 25, 2024 09:39
@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge labels Aug 25, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping itself is fine, need to look through survs for the sec goons

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Sep 7, 2024
@cmss13-ci cmss13-ci bot added the Sprites Remove the soul from the game. label Oct 28, 2024
@BOBAMAx
Copy link
Contributor Author

BOBAMAx commented Oct 28, 2024

now with new blundirised icons, including a new goon medic one.

Picture

goon_medic_ingame

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 29, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added Merge Conflict PR can't be merged because it touched too much code and removed Merge Conflict PR can't be merged because it touched too much code labels Oct 29, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Oct 31, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 19, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 19, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 2, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 2, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants