Increases XO Police skill by 1 #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Balance
|
Duplicate change to #6301 but can leave this up until if/when that closes/merges |
Drulikar
added
the
Balance Approved
Drulikar
approved these changes
Jul 29, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
# About The Pull Request Follow up PR to [#4707](#4707). Aims to expand XO vendors to bring them up to date with modern combat meta, as well as clean up my SO vendor update in the process. - Added gear specializations to the XO weapons vendor, offering the essentials set of either a Medic or Engineer - Adds a Magharn to rail attachments section in the XO weapons vendor - Expanded belt/pouch options in the XO weapons vendor - Added the 'other gear' section in the XO vendor, with various combat supplies Misc. - Fixed XO/SO vendor code so that selecting the autoinjector pouch gives you a full one, rather than empty - ~~Increased XO policing skillset from 1, to 2, so they can actually use the MP belt they are offered~~ (Already done in #6781 ) - Unified the SO armory vendor code into the regular SO vendor file, rather than having two seperate <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game The XO gear vendors have sat untouched in the code for quite some time, and have been left to fall behind the quickly changing meta of CM. With a more updated selection of modern gear, XOs will no longer be significantly out-geared by their Staff Officers when it comes to organizing their combat kits, especially during hijack. XOs will be brought up to par with the gear diversity that SOs have enjoyed for some months now. # Testing Photographs and Procedure Select photos of the updated XO vendor menus, where changes have been made <details>     </details> # Changelog :cl: refactor: SO armory vendor code refactored into the main SO gear vendor code balance: XO weapon and clothing vendors fitted with a more modernized equipment set balance: XO weapon vendor now offers Medic or Engineer essentials sets fix: Vending an autoinjector pouch as SO or XO now produces a full pouch, rather than empty balance: SO's mod88 removed from cryo spawn and moved to their vendor instead /:cl: --------- Co-authored-by: Drathek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Explain why it's good for the game
The XO can choose a MP belt from their own vendor, but cant use most of the items in it.
Either XO is able to use the MP belt from their own vendor, or the MP belt gets removed.
But one of those things needs to change, having a noob trap in the XO role aint cool.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑TheManWithNoHands
balance: increases XO police skill by 1
/:cl: