Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows you to wear the warning cone #6695

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

TheManWithNoHands
Copy link
Contributor

@TheManWithNoHands TheManWithNoHands commented Jul 12, 2024

About the pull request

  • makes the cone fit the head slot
  • Adds on mob sprites for the cone

Explain why it's good for the game

I dont need to explain myself.
You all know why i did this.

Testing Photographs and Procedure

Screenshots & Videos

https://imgur.com/a/8DAFmMK

Changelog

🆑 TheManWithNoHands
code: adds flags to cone, allowing it to be worn on head
imageadd: added on mob sprites for cone

/:cl:

@github-actions github-actions bot added the Sprites Remove the soul from the game. label Jul 12, 2024
@ihatethisengine
Copy link
Contributor

Thank you. It has bothered me for years. God bless you.

@LC4492
Copy link
Contributor

LC4492 commented Jul 12, 2024

Remember to properly set the changelog, you need to write the changes you made on it.

@github-actions github-actions bot added the Code Improvement Make the code longer label Jul 13, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 21, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 21, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Jul 21, 2024

Stale exempt until sprite reviewed. (Though I'm not terribly keen on this regardless)

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites are fine at least 👍

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Stale Exempt PR can't go stale labels Jul 25, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note huggers don't rip it off, but it doesn't block a hug nor decapitation.

@Drulikar Drulikar added this pull request to the merge queue Jul 28, 2024
Merged via the queue into cmss13-devs:master with commit aa56e96 Jul 28, 2024
28 of 29 checks passed
cm13-github added a commit that referenced this pull request Jul 28, 2024
@RavinHobo
Copy link

Finally a truly Scottish PR

@zzzmike
Copy link
Contributor

zzzmike commented Jul 30, 2024

this is long ago merged so no one will probably see this, but just in case, see https://forum.cm-ss13.com/t/campinkiller-player-report-brett-mcmatherson-rule-11-marine-law-mutinies-malicious-compliance/9392/4 for expectations on how this can play out with MPs/provost

@TheManWithNoHands
Copy link
Contributor Author

Oh i read it. And im in love.
This is hilarious.

@TheManWithNoHands TheManWithNoHands deleted the cone-hat branch September 4, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants