Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT6]Drop extra space from the key name #46795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 25, 2024

Latest ROOT master change now warns about the trailing blanks in the key name. As we convert root warnings in to errors so PR relvals are failing [a] with latest root changes. Note that root was always removing the trailing spaces, it is just that in latest root they print a warning

This PR fixes the trailing space for Tof_of_hits

[a]

----- Begin Fatal Exception 25-Nov-2024 15:49:40 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module DQMFileSaver/'dqmSaver'
   Additional Info:
      [a] Fatal Root Error: @SUB=TDirectoryFile::WriteTObject
The key name 'Tof_of_hits ' will be stored in file without the trailing blanks.
----- End Fatal Exception -------------------------------------------------

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Validation/MuonHits (dqm)

@antoniovagnerini, @rseidita can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c60b5/43064/summary.html
COMMIT: 546544c
CMSSW: CMSSW_15_0_X_2024-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46795/43064/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cms-sw cms-sw deleted a comment from cmsbuild Nov 25, 2024
@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 26, 2024

@cms-sw/dqm-l2 , can you please review this? This will allow us to move forward with root master branch changes in ROOT6_X Ibs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants