[UBSAN]Check for finite tracklet seeding or d0 cut

[smuzaffar]

This PR fixes a runtime error (shown in UBSAN IBs [a] workflow 29751.85/step2). This happens when either rinvapprox or d0approx are nan. This change now also check if these variables have finite values. @cms-sw/l1-l2 TrackletCalculatorDisplaced::LLLSeeding(...) also have similar code, so let me know if we should add these check in there.

I also moved https://github.com/cms-sw/cmssw/blob/master/L1Trigger/TrackFindingTracklet/src/TrackletCalculatorDisplaced.cc#L942-L966 code under if (settings_.debugTracklet()) condition ( just to avoid running for loops if settings_.debugTracklet() is not true

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/el8_amd64_gcc12/CMSSW_15_0_UBSAN_X_2024-11-22-2300/pyRelValMatrixLogs/run/29751.85_HydjetQMinBias_5519GeV+Run4D110_hi/step2_HydjetQMinBias_5519GeV+Run4D110_hi.log

src/L1Trigger/TrackFindingTracklet/src/TrackletCalculatorDisplaced.cc:1020:27: runtime error: signed integer overflow: -2147483648 * 2 cannot be represented in type 'int'
    #0 0x1477a984083f in trklet::TrackletCalculatorDisplaced::DDLSeeding(trklet::Stub const*, trklet::L1TStub const*, trklet::Stub const*, trklet::L1TStub const*, trklet::Stub const*, trklet::L1TStub const*) src/L1Trigger/TrackFindingTracklet/src/TrackletCalculatorDisplaced.cc:1020
    #1 0x1477a9af4430 in trklet::TrackletProcessorDisplaced::execute(unsigned int, double, double) src/L1Trigger/TrackFindingTracklet/src/TrackletProcessorDisplaced.cc:296
    #2 0x1477a9494fe8 in trklet::Sector::executeTPD() src/L1Trigger/TrackFindingTracklet/src/Sector.cc:379
    #3 0x1477a99c560c in trklet::TrackletEventProcessor::event(trklet::SLHCEvent&, std::vector<std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, 

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46794/42780

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• L1Trigger/TrackFindingTracklet (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @missirol, @mmusich, @skinnari this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

test parameters:

• workflow = 29751.85

[smuzaffar]

please test

[smuzaffar]

please test for CMSSW_15_0_UBSAN_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f25296/43061/summary.html
COMMIT: 513cdcd
CMSSW: CMSSW_15_0_UBSAN_X_2024-11-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46794/43061/install.sh to create a dev area with all the needed externals and cmssw changes.

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f25296/43060/summary.html
COMMIT: 513cdcd
CMSSW: CMSSW_15_0_X_2024-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46794/43060/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3588437
• DQMHistoTests: Total failures: 577
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3587840
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 207 log files, 176 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)