-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove six python2->3 compatibility helper usage #34534
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34534/24046
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages:
@andrius-k, @gouskos, @lveldere, @chayanit, @bbilin, @wajidalikhan, @sbein, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @tlampen, @jpata, @pohsun, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @fwyzard, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @kskovpen, @slava77, @ggovi, @qliphy, @fabiocos, @francescobrivio, @malbouis, @ssekmen, @jordan-martins, @kmaeshima, @silviodonato, @srimanob, @fgolf, @mariadalfonso, @tvami, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
@smuzaffar
My default shell is tcsh, but same error if I switch to sh |
+l1 |
what type of error you get @Martin-Grunewald ? For me it works on lxplus. |
See above the output of the scripts, esp the two utf8 errors:
and if I then try to add another PR, I get this error:
|
please ignore the |
OK, thanks for the clarification! |
+1 |
merge |
+1 |
(breaks python2 compatibility) - done mostly via script, lets see what mistakes my script made..