Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove six python2->3 compatibility helper usage #34534

Merged
merged 8 commits into from
Jul 22, 2021

Conversation

davidlange6
Copy link
Contributor

(breaks python2 compatibility) - done mostly via script, lets see what mistakes my script made..

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34534/24046

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

  • Alignment/HIPAlignmentAlgorithm (alca)
  • Alignment/MillePedeAlignmentAlgorithm (alca)
  • Alignment/OfflineValidation (alca)
  • CalibTracker/SiStripDCS (alca)
  • CalibTracker/SiStripESProducers (alca)
  • CommonTools/ParticleFlow (reconstruction)
  • CondCore/ESSources (db, alca)
  • CondTools/BTau (db)
  • CondTools/SiStrip (db)
  • Configuration/AlCa (alca)
  • Configuration/Applications (operations)
  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DQM/Integration (dqm)
  • DQM/SiStripMonitorClient (dqm)
  • DQM/TrackerRemapper (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Configuration (dqm)
  • DQMOffline/L1Trigger (dqm, l1)
  • FWCore/Concurrency (core)
  • FWCore/Modules (core)
  • FWCore/ParameterSet (core)
  • FWCore/PythonUtilities (core)
  • FWCore/Services (core)
  • FWCore/Utilities (core)
  • FastSimulation/TrackingRecHitProducer (fastsim)
  • HLTrigger/Configuration (hlt)
  • HLTrigger/HLTanalyzers (hlt)
  • HLTrigger/Tools (hlt)
  • HLTriggerOffline/Egamma (dqm)
  • HeterogeneousCore/SonicTriton (heterogeneous)
  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TCalorimeter (l1)
  • L1Trigger/L1TMuonEndCap (l1)
  • L1TriggerConfig/Utilities (l1)
  • PhysicsTools/Heppy (analysis)
  • PhysicsTools/HeppyCore (analysis)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (reconstruction)
  • PhysicsTools/PythonAnalysis (analysis)
  • PhysicsTools/Utilities (analysis)
  • RecoBTag/ONNXRuntime (reconstruction)
  • RecoLuminosity/LumiDB (db)
  • RecoTauTag/Configuration (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)
  • RecoTracker/Configuration (reconstruction)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)
  • SimG4CMS/HGCalTestBeam (upgrade, simulation)
  • TauAnalysis/MCEmbeddingTools (simulation)
  • Utilities/RelMon (dqm)
  • Utilities/ReleaseScripts (core)
  • Validation/Configuration (dqm, simulation)
  • Validation/Geometry (geometry, dqm)
  • Validation/HGCalValidation (dqm)
  • Validation/RecoB (dqm)
  • Validation/RecoTau (dqm)
  • Validation/RecoTrack (dqm)
  • Validation/Tools (core)

@andrius-k, @gouskos, @lveldere, @chayanit, @bbilin, @wajidalikhan, @sbein, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @tlampen, @jpata, @pohsun, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @fwyzard, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @kskovpen, @slava77, @ggovi, @qliphy, @fabiocos, @francescobrivio, @malbouis, @ssekmen, @jordan-martins, @kmaeshima, @silviodonato, @srimanob, @fgolf, @mariadalfonso, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@wmtford, @echabert, @rappoccio, @gouskos, @hdelanno, @felicepantaleo, @jandrea, @robervalwalsh, @emilbols, @kpedro88, @gbenelli, @Martin-Grunewald, @bsunanda, @pfs, @thomreis, @tlampen, @mbluj, @rishabhCMS, @threus, @mmusich, @seemasharmafnal, @venturia, @mmarionncern, @sethzenz, @apsallid, @makortel, @JanFSchulte, @dgulhan, @missirol, @JyothsnaKomaragiri, @slomeo, @sroychow, @jdamgov, @lgray, @mariadalfonso, @vandreev11, @pieterdavid, @cvuosalo, @GiacomoSguazzoni, @tocheng, @VinInn, @cseez, @gpetruc, @nhanvtran, @gkasieczka, @rovere, @schoef, @idebruyn, @ebrondol, @mtosi, @fabiocos, @clelange, @rbartek, @arossi83, @batinkov, @swertz, @adewit, @riga, @battibass, @swozniewski, @wddgit, @jdolen, @ahinzmann, @hatakeyamak, @vargasa, @lecriste, @cbernet, @dinyar, @matt-komm, @andrzejnovak, @rociovilar, @fioriNTU this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Jul 22, 2021

@smuzaffar
I can't get the script to work making a developer area with this this PR as advertised above:

/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34534/17027/install.sh
++ /bin/pwd
+ XDIR=/data/CMS0/test
+ export SCRAM_ARCH=slc7_amd64_gcc900
+ SCRAM_ARCH=slc7_amd64_gcc900
+ '[' -e CMSSW_12_0_X_2021-07-20-1100 ']'
+ tar -xzf /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34534/17027/cmssw.tar.gz
+ cd CMSSW_12_0_X_2021-07-20-1100
++ cat config/scram_version
+ SCRAM_VER=V3_00_30
+ EXT=pl
+ SCRAM_HOME_BASE=src
++ echo V3_00_30
++ grep '^V3'
++ wc -l
+ '[' 1 -gt 0 ']'
+ EXT=py
+ SCRAM_HOME_BASE=
+ export SCRAM_TOOL_HOME=/cvmfs/cms-ib.cern.ch/week0/share/lcg/SCRAMV1/V3_00_30/
+ SCRAM_TOOL_HOME=/cvmfs/cms-ib.cern.ch/week0/share/lcg/SCRAMV1/V3_00_30/
+ ./config/SCRAM/projectAreaRename.py /data/cmsbld/jenkins/workspace/ib-run-pr-tests /data/CMS0/test slc7_amd64_gcc900
'utf-8' codec can't decode byte 0x84 in position 8: invalid start byte Error: Unable to read file /data/CMS0/test/CMSSW_12_0_X_2021-07-20-1100/config/SCRAM/Plugins/CMSSW/__pycache__/ExtraBuildRule.cpython-38.pyc
'utf-8' codec can't decode byte 0x84 in position 8: invalid start byte Error: Unable to read file /data/CMS0/test/CMSSW_12_0_X_2021-07-20-1100/config/SCRAM/Plugins/__pycache__/BuildRules.cpython-38.pyc
+ ./config/SCRAM/linkexternal.py --arch slc7_amd64_gcc900
+ find config/SCRAM -name __pycache__ -type d
+ xargs --no-run-if-empty rm -rf

My default shell is tcsh, but same error if I switch to sh

@cecilecaillol
Copy link
Contributor

+l1

@smuzaffar
Copy link
Contributor

what type of error you get @Martin-Grunewald ? For me it works on lxplus. /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34534/17027/install.sh creates local CMSSW_12_0_X_2021-07-20-1100 directory and I can go in there, setup env (cmsenv) and use the area.

@Martin-Grunewald
Copy link
Contributor

See above the output of the scripts, esp the two utf8 errors:

'utf-8' codec can't decode byte 0x84 in position 8: invalid start byte Error: Unable to read file /data/CMS0/test/CMSSW_12_0_X_2021-07-20-1100/config/SCRAM/Plugins/CMSSW/__pycache__/ExtraBuildRule.cpython-38.pyc
'utf-8' codec can't decode byte 0x84 in position 8: invalid start byte Error: Unable to read file /data/CMS0/test/CMSSW_12_0_X_2021-07-20-1100/config/SCRAM/Plugins/__pycache__/BuildRules.cpython-38.pyc

and if I then try to add another PR, I get this error:

git cms-merge-topic 34563
From .
 * [new ref]                            -> merge-attempt
From https://github.com/cms-sw/cmssw
 * [new ref]                 refs/pull/34563/head -> cms-sw/refs/pull/34563/head
Switched to branch 'merge-attempt'
fatal: unable to read tree 48bba69e8b701357dac0b29ecf33807d78524848

@smuzaffar
Copy link
Contributor

please ignore the 'utf-8' codec can't decode byte 0x84 type messages. The area is build and populated with PR #34534 contents. I do not think that you can run another git cms-merge-topic ... there. This area is provided so that you can re-run the tests to debug. What do you want to achieve? If you just want to test #34563 with #34534 then why not start PR test for #34563 with extra PR #34534?

@Martin-Grunewald
Copy link
Contributor

OK, thanks for the clarification!

@ggovi
Copy link
Contributor

ggovi commented Jul 22, 2021

+1

@silviodonato
Copy link
Contributor

merge

@santocch
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment