-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move scripts in Utilties and Validation to py3 #34364
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34364/23739
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Utilities/ReleaseScripts @smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @makortel, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
as @smuzaffar suggested I ran python3 -m compileall on these and fixed the corresponding problems. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34364/23742
|
Pull request #34364 was updated. @smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @makortel, @jfernan2, @rvenditti can you please check and sign again. |
Co-authored-by: Matti Kortelainen <[email protected]>
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34364/23752
|
Pull request #34364 was updated. @smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @makortel, @jfernan2, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfe12e/16519/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
I do not believe that anything changed is used in unit tests...