Enable mkFit for initialStepPreSplitting with trackingMkFit modifier #34198

makortel · 2021-06-21T14:27:22Z

PR description:

This PR extends the mkFit setup (enabled with trackingMkFit modifier, X.7 workflows) to use mkFit in initialStepPreSplitting, as mentioned in TRK POG meeting 2021-06-14.

This PR also includes a technical fix to include a header of PropagatorWithMaterial instead of its source file (I have no idea how that ended up there).

PR validation:

Workflows 11634.0, 11634.7 run.

cmsbuild · 2021-06-21T14:36:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34198/23415

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/RecoTrack/python/plotting/trackingPlots.py modified in PR(s): EXO regional tracking iteration #32806

cmsbuild · 2021-06-21T14:36:36Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/ProcessModifiers
RecoTracker/IterativeTracking
RecoTracker/MkFit
Validation/RecoTrack

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @silviodonato, @jfernan2, @slava77, @jpata, @qliphy, @davidlange6, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @wmtford, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2021-06-21T14:39:57Z

@cmsbuild, please test

makortel · 2021-06-21T14:41:41Z

@cmsbuild, please abort

makortel · 2021-06-21T14:42:20Z

test parameters:

workflows = 11634.7

makortel · 2021-06-21T14:42:28Z

@cmsbuild, please test

cmsbuild · 2021-06-21T17:49:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-870ac7/16140/summary.html
COMMIT: 5e34756
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34198/16140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785631
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2785596
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

jpata

@mtosi @vmariani please let us know if you have additional comments/concerns.

jpata · 2021-06-22T07:52:25Z

RecoTracker/IterativeTracking/python/InitialStepPreSplitting_cff.py

+from Configuration.ProcessModifiers.trackingMkFitInitialStepPreSplitting_cff import trackingMkFitInitialStepPreSplitting
+from RecoTracker.MkFit.mkFitGeometryESProducer_cfi import mkFitGeometryESProducer
+import RecoTracker.MkFit.mkFitSiPixelHitConverter_cfi as mkFitSiPixelHitConverter_cfi
+import RecoTracker.MkFit.mkFitSiStripHitConverter_cfi as mkFitSiStripHitConverter_cfi
+import RecoTracker.MkFit.mkFitEventOfHitsProducer_cfi as mkFitEventOfHitsProducer_cfi
+import RecoTracker.MkFit.mkFitSeedConverter_cfi as mkFitSeedConverter_cfi
+import RecoTracker.MkFit.mkFitIterationConfigESProducer_cfi as mkFitIterationConfigESProducer_cfi
+import RecoTracker.MkFit.mkFitProducer_cfi as mkFitProducer_cfi
+import RecoTracker.MkFit.mkFitOutputConverter_cfi as mkFitOutputConverter_cfi


sorry if I miss something, but should/could these be hidden from re-exporting (prefixed with _)?

I changed only the InitialStepPreSplitting_cff.py that was modified in this PR. If you wish, I can change the other iterations where mkFit can be enabled accordingly as well.

thanks! maybe the other iterations can be changed in a (technical) follow-up?

RecoTracker/IterativeTracking/python/InitialStepPreSplitting_cff.py

cmsbuild · 2021-06-22T13:52:10Z

Pull request #34198 was updated. @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @silviodonato, @jfernan2, @slava77, @jpata, @qliphy, @davidlange6, @fabiocos, @rvenditti can you please check and sign again.

makortel · 2021-06-22T13:57:00Z

@cmsbuild, please test

cmsbuild · 2021-06-22T17:09:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-870ac7/16164/summary.html
COMMIT: eac614f
CMSSW: CMSSW_12_0_X_2021-06-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34198/16164/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785631
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2785608
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

jpata · 2021-06-25T06:25:01Z

+reconstruction

mkFit in initialStepPreSplitting with a modifier
the mkFit workflow 11634.7 runs
no reco differences in standard workflows

jfernan2 · 2021-06-25T07:19:18Z

+1

qliphy · 2021-06-26T07:42:43Z

+1

cmsbuild · 2021-06-26T07:43:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_12_0_X milestone Jun 21, 2021

makortel mentioned this pull request Jun 21, 2021

Make PR for initialStepPreSplitting cms-sw/framework-team#175

Closed

cmsbuild added code-checks-pending dqm-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 21, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 21, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2021

cmsbuild added tests-pending and removed tests-started labels Jun 21, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 21, 2021

jpata reviewed Jun 22, 2021

View reviewed changes

makortel added 2 commits June 22, 2021 06:43

Add option to run mkFit in initialStepPreSplitting

8f0a66a

Fix include in MkFitOutputConverter

eac614f

makortel force-pushed the mkFitInitialStepPreSplitting branch from 5e34756 to eac614f Compare June 22, 2021 13:44

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 22, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2021

This was referenced Jun 22, 2021

shift legend's position in MTV tuning plots #34210

Merged

Update L1 tracking for HL-LHC (fixed) #34028

Closed

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 25, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Jun 25, 2021

makortel mentioned this pull request Jun 25, 2021

Migrate other iterations use _ in imports cms-sw/framework-team#177

Closed

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Jun 26, 2021

cmsbuild merged commit b6b0924 into cms-sw:master Jun 26, 2021

mmasciov mentioned this pull request Jun 28, 2021

Fixing missing comma in trackingPlots #34268

Merged

makortel deleted the mkFitInitialStepPreSplitting branch June 29, 2021 01:04

mmasciov mentioned this pull request Jul 8, 2021

Update mkFit to support additional tracking iterations and other technical developments #34395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable mkFit for initialStepPreSplitting with trackingMkFit modifier #34198

Enable mkFit for initialStepPreSplitting with trackingMkFit modifier #34198

makortel commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

makortel commented Jun 21, 2021

makortel commented Jun 21, 2021

makortel commented Jun 21, 2021

makortel commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

jpata left a comment

jpata Jun 22, 2021

makortel Jun 22, 2021

makortel Jun 22, 2021

jpata Jun 25, 2021

cmsbuild commented Jun 22, 2021

makortel commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

jpata commented Jun 25, 2021

jfernan2 commented Jun 25, 2021

qliphy commented Jun 26, 2021

cmsbuild commented Jun 26, 2021

Enable mkFit for initialStepPreSplitting with trackingMkFit modifier #34198

Enable mkFit for initialStepPreSplitting with trackingMkFit modifier #34198

Conversation

makortel commented Jun 21, 2021

PR description:

PR validation:

cmsbuild commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

makortel commented Jun 21, 2021

makortel commented Jun 21, 2021

makortel commented Jun 21, 2021

makortel commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

Comparison Summary

jpata left a comment

Choose a reason for hiding this comment

jpata Jun 22, 2021

Choose a reason for hiding this comment

makortel Jun 22, 2021

Choose a reason for hiding this comment

makortel Jun 22, 2021

Choose a reason for hiding this comment

jpata Jun 25, 2021

Choose a reason for hiding this comment

cmsbuild commented Jun 22, 2021

makortel commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

Comparison Summary

jpata commented Jun 25, 2021

jfernan2 commented Jun 25, 2021

qliphy commented Jun 26, 2021

cmsbuild commented Jun 26, 2021