Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889

VinInn · 2021-05-29T08:31:55Z

Introducing Quality for PixelTracks.
Legacy promoted to HighPurity.
Patatrack duplicate and ambiguity resolution improved.
Added few more configurable to manage SoA to Legacy conversion.
PixelTrack DQM and MTV modified to account for quality (thanks to @mtosi )

no regression expected besides patatrack
(and histos that may have changed folder)

Full details in the presentation at TRK-POG on 31/5/2021 https://indico.cern.ch/event/1039044/
https://indico.cern.ch/event/1039044/contributions/4364006/attachments/2253950/3824134/PataQuality.pdf

jfernan2 · 2021-06-08T07:22:27Z

HLT Tau and Tracking differences are gone now, only changes in the GPU comparison

VinInn · 2021-06-08T09:06:14Z

OK. let's leave it like this for now with the comment. In any case case Tau is supposed to review their HLT tracking as other inconsistencies have been found.

jpata · 2021-06-08T10:31:07Z

+reconstruction

no major reco changes observed (hiConformalPixelTracks__reRECO_obj_qualityMask is now filled), some minor GPU reco changes are observed
note that a regression was observed with HLT taus, reverted by 02ba022 (cc @mbluj @swozniewski)

jfernan2 · 2021-06-08T10:41:31Z

+1

mmusich · 2021-06-14T10:08:41Z

@cms-sw/heterogeneous-l2 any further comment?

makortel · 2021-06-14T15:46:36Z

any further comment?

@fwyzard wants to run some performance tests and will get back tomorrow morning.

fwyzard · 2021-06-14T20:11:21Z

Validation plots

/RelValTTbar_14TeV/CMSSW_11_3_0_pre5-PU_113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.505
tracking validation plots and summary for workflow 11634.502
tracking validation plots and summary for workflow 11634.506

/RelValZMM_14/CMSSW_11_3_0_pre5-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflow 11634.501
tracking validation plots and summary for workflow 11634.505
tracking validation plots and summary for workflow 11634.502
tracking validation plots and summary for workflow 11634.506

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_3_0_pre5-PU_113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501
tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZMM_14/CMSSW_11_3_0_pre5-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

tracking validation plots and summary for workflows 11634.502 and 11634.501
tracking validation plots and summary for workflows 11634.506 and 11634.505

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and `nvprof`/`nvvp` profiles

/RelValTTbar_14TeV/CMSSW_11_3_0_pre5-PU_113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.501
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.505
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.511
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.521
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.501
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.505
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.511
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.521
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors

/RelValZMM_14/CMSSW_11_3_0_pre5-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.501
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.505
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.511
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.521
- ✔️ step3.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.501
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.505
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.502
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.506
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.511
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.512
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.521
- ✔️ step3.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 11634.522
- ✔️ step3.py: log
- ✔️ profile.py: log
- ✔️ compute-sanitizer --tool initcheck (report, log) did not find any errors
- ✔️ compute-sanitizer --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
- ✔️ compute-sanitizer --tool synccheck (report, log) did not find any errors

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 136.885502
- ✔️ step3.py: log
- ✔️ profile.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 136.885512
- ✔️ step3.py: log
- ✔️ profile.py: log
reference/CMSSW_12_0_X_2021-06-06-2300 release, workflow 136.885522
- ✔️ step3.py: log
- ✔️ profile.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 136.885502
- ✔️ step3.py: log
- ✔️ profile.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 136.885512
- ✔️ step3.py: log
- ✔️ profile.py: log
testing/CMSSW_12_0_X_2021-06-06-2300 release, workflow 136.885522
- ✔️ step3.py: log
- ✔️ profile.py: log

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/bafab52630683bb364cd54c497be78a4f2bc00a5/log .

fwyzard · 2021-06-14T23:05:20Z

Looks like everything worked out, except the throughput measurements... will check tomorrow.

jpata · 2021-06-17T13:40:57Z

Hi, just a kind ping.

fwyzard · 2021-06-18T07:10:50Z

OK, so the measurements did run, it is just the final plots that were not made... and now, here they are:

136.885502

136.885512

136.885522

fwyzard · 2021-06-18T07:11:48Z

Looking at 136.885502 there seems to be a small impact... or it could be just "noise" on the machine running the test.

fwyzard · 2021-06-18T07:11:58Z

Anyway, looks OK to me.

fwyzard · 2021-06-18T07:12:59Z

+heterogeneous

cmsbuild · 2021-06-18T07:13:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-18T12:02:24Z

+1

VinInn added 30 commits April 17, 2021 11:29

define first level quality

624b3f6

implement a 0 order quality for patatracks

d2cdb1f

code format

928a938

fix references to loose

3f74004

fix quality critera in duplicate killer

eefdc4c

add passthrough for quads

45035ed

fix DQM

1e5e7b9

first step toward quality in MTV and DQM

160a1ff

fix MTV config

9cd0761

fix validation and DQM

ca89c9b

remove obsolete file

3b9760d

more fix

c32a065

start working (running(

143c4e5

new classification

3a71b2d

fix mtv classification

d0fc835

remove masking from Tformula

1c7a7c7

make quality inclusive, fix PV plots

0e13c3e

add full combi

073ef2d

make compatibility eta dependent

a63bfcd

back to 05

194995d

Merged PxTkQuality from repository VinInn with cms-merge-topic

f0cdb9f

factorize reject flag

918f6f4

make dup pass through configurable

d9926bd

speed up conversion

de3fe29

add reserve

8ea1882

add kernel to mark triplets sharing n-hit with quads

f5cc6fc

invoke new sharedHit cleaners

e3ab482

remove shared killer, add eta cut for duplicates

1f6962f

code format

6087acf

introduce new early duplicate quality

03ca0af

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 8, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Jun 8, 2021

cmsbuild added fully-signed heterogeneous-approved and removed heterogeneous-pending pending-signatures labels Jun 18, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 18, 2021

cmsbuild merged commit 252577a into cms-sw:master Jun 18, 2021

slava77 mentioned this pull request Jun 18, 2021

Code cleanliness improvements in follow-up to #31722 #33865

Closed

This was referenced Jun 18, 2021

remove unused KFFittingSmootherESProducer.h #34179

Merged

Validation/RecoMuon HTrack: make a copy instead of a reference to a temporary #34183

Merged

fwyzard mentioned this pull request Jun 23, 2021

[cudadev] Update the CUDA implementation to the version in CMSSW 12.0.0-pre3 cms-patatrack/pixeltrack-standalone#191

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889

Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889

VinInn commented May 29, 2021

jfernan2 commented Jun 8, 2021

VinInn commented Jun 8, 2021

jpata commented Jun 8, 2021 •

edited

Loading

jfernan2 commented Jun 8, 2021

mmusich commented Jun 14, 2021

makortel commented Jun 14, 2021

fwyzard commented Jun 14, 2021

fwyzard commented Jun 14, 2021

jpata commented Jun 17, 2021

fwyzard commented Jun 18, 2021

fwyzard commented Jun 18, 2021

fwyzard commented Jun 18, 2021

fwyzard commented Jun 18, 2021

cmsbuild commented Jun 18, 2021

qliphy commented Jun 18, 2021

Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889

Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889

Conversation

VinInn commented May 29, 2021

jfernan2 commented Jun 8, 2021

VinInn commented Jun 8, 2021

jpata commented Jun 8, 2021 • edited Loading

jfernan2 commented Jun 8, 2021

mmusich commented Jun 14, 2021

makortel commented Jun 14, 2021

fwyzard commented Jun 14, 2021

Validation plots

/RelValTTbar_14TeV/CMSSW_11_3_0_pre5-PU_113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_3_0_pre5-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_3_0_pre5-PU_113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_3_0_pre5-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_3_0_pre5-PU_113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_3_0_pre5-113X_mcRun3_2021_realistic_v7-v1/GEN-SIM-DIGI-RAW

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

Logs

fwyzard commented Jun 14, 2021

jpata commented Jun 17, 2021

fwyzard commented Jun 18, 2021

136.885502

136.885512

136.885522

fwyzard commented Jun 18, 2021

fwyzard commented Jun 18, 2021

fwyzard commented Jun 18, 2021

cmsbuild commented Jun 18, 2021

qliphy commented Jun 18, 2021

jpata commented Jun 8, 2021 •

edited

Loading

logs and `nvprof`/`nvvp` profiles