Update L1 tracking for HL-LHC #33837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Various changes for outputting PurgeDuplicates test-vectors. * Removed some magic numbers. * Updated trackfitstr() to be more readable and include more comments. * Removed more magic.
* Update max steps per TM period to match HLS * Updated MC dataset
* add beam spot constraint flag to save new bcon values * add check on scaled chi2 value after beam constraint * get rid of code duplication * include comment on kalmanAddBeamConstr_ boolean * take out unecessary function
* Anders DTC merge with a gazillion manual fixes * propagate buildfile fixes * code formats * fix cherrypick mess up * Remove LayerProjection class * Further cleanup of tracklet projections interface * Correct number of processing steps by changing < to <= * Add missing include of algorithm * Remove extra const * Remove some commented out code * Remove duplicate code * Fix message logger and DTC Stub for consistency with hybrid configuration * Fix problem with writing of input link memories * Create Residual class that will replace LayerResidual and DiskResidual * Remove the use of the class DiskResiduals * Remove unused nMatch and nMatchDisk method of Tracklet * (Re-)Implement the correction to writing the DTC data link file after moving functionality to Sector. * Combine addMatch method for disk and layers into on method * combine the disk and layer match into one method * Remove some redundant poiters to l1tstubs * Pass iSeed to Tracklet * Introduce an InputRouter module. Does not change functionality, but simplifies/unifies the code and makes it similar to the HLS * Cleanup of writing the DTC link files * Change processing order such that all steps in one sector are done and then move to the next sector. This saves memory * Interface updates for CMSSW following change to module processing order * Change in VMRouter to processing PS links before 2S in disks * Cleanup of unused iSector variable in processs and memory modules * Fixes to make the HybridTracks_cfg.py run * Cleanup of hardcoded numbers etc. * Updates to MP to put all regions into one memory slot in the ProjectionTemp * Fix to calculation of irinv for projections - no matches what is done in HLS * Remove now unused file paths for the old cable mapping code * Correct missplaced curly bracket * Fixes for the displaced tracking * Fix to avoid duplicate VMSTE name in D1 for standard configuration * Address comments from Louise S. * Ran scram b code-format * Address comments from Louise S. * Addressing more comments from Louise S. * More fixes to comments * Make running hybrid default (not displaced) * restore buildfile * Add DTC link config to Settings.h * Changes to suppress warning in MatchCalculator when running displaced tracking * Fix typo introduced in code cleanup for MatchProcessor Co-authored-by: Anders Ryd <[email protected]> Co-authored-by: Anders <[email protected]>
* Fix to compiler warning and removal of hardoded value in MatchCalculator * Updates to fix names of pins to make unique Co-authored-by: Anders Ryd <[email protected]>
* Fix to compiler warning and removal of hardoded value in MatchCalculator * Updates to fix names of pins to make unique * Migrate to new format of table for phi correction memory * Remove unused TETableBase class * Cleanup of VMRouterTable * Cleanup of LUT for bend consistency * Cleanup of LUT used in MEU for bend consistency * Cleanup code for disk bend table * cleanup of code to generate table used by TE * Cleanup of TP LUTs * Cleanup of LUTs for MatchCalculator cuts * Fix names of new LUT when writing to files * Cleanup of writing LUTs for the combined modules * Add code to write projection bend table for disk projections * More cleanup to remove hard coded layer and seed numbers * Cleanup of hardcoded numbers * Remove few more hardcoded constants: * Some further cleanup based on comments from Louise S. Co-authored-by: Anders Ryd <[email protected]> Co-authored-by: Louise Skinnari <[email protected]>
* Updates to MatchProcessor so that we can get full agreement with HLS version * Fix to LUT for adding stub in VMStubsTEMemory when running extendted tracking Co-authored-by: Anders Ryd <[email protected]>
…ing (#82) * Corrections to fix updates to new LUTs that broke the displaced tracking * Fix compile errors in CMSSW * Remove commented out code Co-authored-by: Louise Skinnari <[email protected]>
* fix matchtp variables * remove d=0 variables * switch values for cms constants * change pi to constant * change trk_d0 sign * move tmp_tp_d0 and tmp_tp_z0 calc up * flip tp_d0 sign
|
A new Pull Request was created by @skinnari (Louise Skinnari) for CMSSW_11_3_X. It involves the following packages: L1Trigger/TrackFindingTMTT @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test with cms-data/L1Trigger-TrackFindingTracklet#3 |
|
-1 Failed Tests: RelVals RelVals-INPUT RelValsExpand to see more relval errors ...RelVals-INPUT
|
|
@skinnari please make a PR to master |
|
The missing file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglass.dat is provided in the separate PR https://github.com/cms-data/L1Trigger-TrackFindingTracklet/pull/3/files |
|
Just to clarify that this is not the issue as the PRs are being tested jointly. The problem is understood and will be fixed along with updated to make the PR to master branch instead. |
|
I have now opened a new PR to master branch instead (#34028) so I am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR includes updates to the L1 tracking for HL-LHC:
Note:
PR validation:
Validated via L1 tracking performance studies on ttbar PU=200 samples.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is not a backport.