Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GEM offline DQM, backport to 11_1_X #31819

Conversation

seungjin-yang
Copy link
Contributor

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30468 and #31818 for enabling GEM offline DQM during MWGR.

#30468 created GEM offline DQM modules and python configuration files but GEM offline DQM source sequence wasn't included in DQMOfflineCosmics sequence for the comics scenario. So #31818 solved it.

@jshlee @watson-ij @szaleski

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @seungjin-yang for CMSSW_11_1_X.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/Muon

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @bellan, @threus, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@seungjin-yang seungjin-yang changed the title Added GEM offlien DQM. Added GEM offlien DQM, backport to 11_1_X Oct 16, 2020
@seungjin-yang seungjin-yang changed the title Added GEM offlien DQM, backport to 11_1_X Add GEM offline DQM, backport to 11_1_X Oct 16, 2020
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: c2c4005
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-047d8c/10012/summary.html
CMSSW: CMSSW_11_1_X_2020-10-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-047d8c/10012/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2781012
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780961
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1620.536 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 144.873 KiB GEM/GEMEfficiency
  • DQMHistoSizes: changed ( 11634.0,... ): 20.975 KiB GEM/GEMOfflineMonitor
  • DQMHistoSizes: changed ( 20034.0,... ): 218.818 KiB GEM/GEMEfficiency
  • DQMHistoSizes: changed ( 20034.0,... ): 38.949 KiB GEM/GEMOfflineMonitor
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 17, 2020

+1

@cmsbuild cmsbuild merged commit b6d7de8 into cms-sw:CMSSW_11_1_X Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants