Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano gen dqm #31591

Merged
merged 8 commits into from
Oct 20, 2020
Merged

Nano gen dqm #31591

merged 8 commits into from
Oct 20, 2020

Conversation

kdlong
Copy link
Contributor

@kdlong kdlong commented Sep 26, 2020

PR description:

This PR adds runTheMatrix support and DQM for the NanoGen workflow, addressing the first item of #31393. A few changes to the NanoGen configs are also made to fix small issues and to simplify the setup.

Only one validation workflow is added currently, starting with a GEN step. In principle a step with MiniAOD input would also be relevant.

As discussed previously, the inputs should be modified based on if the input event content is MiniAOD-like or GEN-like. In the cmsDriver implementation, this is just decided by seeing if the GEN step is run in the cmsDriver command. If a GEN file is input and only one step is run, it expects Mini. Maybe there is a better way to detect this, but for now I just called the customize command for GEN input explicitly.

PR validation:

I checked that ./runTheMatrix.py -l 595 runs and gives sensible output. The DQM workflow also runs, but I didn't actually check that the plots are produced correctly. Is there an easy tool to see all the plots it creates?

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31591/18644

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kdlong (Kenneth Long) for master.

It involves the following packages:

Configuration/PyReleaseValidation
DQMOffline/Configuration
PhysicsTools/NanoAOD

@andrius-k, @gouskos, @jordan-martins, @chayanit, @wajidalikhan, @ErnestaP, @kpedro88, @cmsbuild, @kmaeshima, @jfernan2, @fgolf, @fioriNTU, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @gpetruc, @threus, @fabiocos, @slomeo, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31591/18645

@cmsbuild
Copy link
Contributor

Pull request #31591 was updated. @andrius-k, @gouskos, @jordan-martins, @chayanit, @wajidalikhan, @ErnestaP, @kpedro88, @cmsbuild, @kmaeshima, @jfernan2, @fgolf, @fioriNTU, @mariadalfonso, @santocch, @peruzzim can you please check and sign again.

@mariadalfonso
Copy link
Contributor

please test workflow 595

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2020

The tests are being triggered in jenkins.
Test Parameters:

@agrohsje
Copy link

+1

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

@kpedro88 ?

@silviodonato
Copy link
Contributor

urgent

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants