-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added RecoTracker-DisplacedRegionalTracking in cmssw deps #8318
Conversation
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_1_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
seems that technically cms-sw/cmssw#40643 run with this addition. Should it be just merged? |
@mmusich , this should go in along with cms-sw/cmssw#40643 . I would suggest to wait for cms-sw/cmssw#40643 to fully signed and then we can include it. |
is there a strong reason to not merge now? |
@mmusich , this is a new data external and it is still not part of cmssw distribution. I would like to not include it in distribution unless the cmssw changes which require it converge. #6907 was opened 20months ago to include this data external but the cmssw PR cms-sw/cmssw#32806 did not converge. So I would suggest to wait for cms-sw/cmssw#40643 to converge first |
recall that a requirement for an external triggers the PR tests to use the head of the IB and could introduce unwanted differences (and repeated tests until by luck there are no relevant new PRs). So, unless merging the external breaks the baseline, perhaps it's worth to consider changing the policy and merge? |
@smuzaffar, while I see from where you are coming from, I really think that this time the PR is set to converge on a reasonable timescale (as there is push from physics to have it). |
itis merged now |
No description provided.