Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RecoTracker-DisplacedRegionalTracking V00-01-00 data #8314

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Feb 14, 2023

needed in context of testing cms-sw/cmssw#40643

I'm guessing that the external was not propagated to the cmsdist because that part was still manual 2 years ago; but perhaps also because the underlying PR cms-sw/cmssw#32806 was not merged back then

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

SimTransport-HectorProducer=V01-00-01
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea why this diff showed up. I was editing online and modified only the first lines (above)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this happens when previously bot had edited the file and might have removed a new line or line feed char. So do not worry about it

@smuzaffar
Copy link
Contributor

@slava77 , the PR #6907 was closed as the cmssw PE cms-sw/cmssw#32806 which needed it was closed too.

@mmusich
Copy link

mmusich commented Feb 15, 2023

is there anything preventing this to be merged? It seems it's needed in order to have meaningful tests at cms-sw/cmssw#40643

@perrotta
Copy link
Contributor

+1

  • As far as I can see it does not interact with any other workflow

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23b162/30642/summary.html
COMMIT: 26759b8
CMSSW: CMSSW_13_1_X_2023-02-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8314/30642/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23b162/30642/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23b162/30642/git-merge-result

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556247
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aandvalenzuela aandvalenzuela merged commit eb46335 into cms-sw:IB/CMSSW_13_1_X/master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants