Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4][geant4_only] Update geant4 to 10.7.2 #7042

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

mrodozov
Copy link
Contributor

Get the latest G4 tag in the G4 IB

Get the latest G4 tag in the G4 IB
@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/geant4.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308be7/16087/summary.html
COMMIT: 99fe5bf
CMSSW: CMSSW_12_0_GEANT4_X_2021-06-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7042/16087/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308be7/16087/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308be7/16087/git-merge-result

Build

I found compilation error when building:

Entering library rule at src/RecoTracker/MkFit/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/RecoTracker/MkFit/plugins/MkFitInputConverter.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/RecoTracker/MkFit/plugins/MkFitOutputConverter.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/RecoTracker/MkFit/plugins/MkFitProducer.cc: In constructor 'MkFitProducer::MkFitProducer(const edm::ParameterSet&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/RecoTracker/MkFit/plugins/MkFitProducer.cc:58:29: error: no match for 'operator=' (operand types are 'std::function' and 'double(mkfit::Event&, const mkfit::EventOfHits&, mkfit::MkBuilder&)')
   58 |     buildFunction_ = mkfit::runBuildingTestPlexBestHit;
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /cvmfs/cms-ib.cern.ch/nweek-02685/slc7_amd64_gcc900/external/gcc/9.3.0/include/c++/9.3.0/functional:59,
                 from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/DataFormats/Provenance/interface/Hash.h:5,
                 from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_GEANT4_X_2021-06-15-2300/src/DataFormats/Provenance/interface/ParentageID.h:5,


@civanch
Copy link
Contributor

civanch commented Jun 18, 2021

@mrodozov , it is not clear why there is build error in RECO sub-library while only Geant4 version is changed.

@mrodozov
Copy link
Contributor Author

mrodozov commented Jun 18, 2021

@civanch we don't have a fresh IB that includes this change in mkFit . This evening we'll have it and restart the test
the IB used here is CMSSW_12_0_GEANT4_X_2021-06-15-2300 which doesn't include the change needed.
We don't build that IB everyday as we do for other releases

@mrodozov
Copy link
Contributor Author

please test
now we have geant4 IB (since this evening)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308be7/16113/summary.html
COMMIT: 99fe5bf
CMSSW: CMSSW_12_0_GEANT4_X_2021-06-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7042/16113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 52079 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785631
  • DQMHistoTests: Total failures: 282598
  • DQMHistoTests: Total nulls: 231
  • DQMHistoTests: Total successes: 2502780
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.144 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.244 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.225 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -1.120 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.493 KiB SiStrip/MechanicalView
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 14 / 37 workflows

@civanch
Copy link
Contributor

civanch commented Jun 19, 2021

@mrodozov , I think the test is now positive, the fact that simulations histories are different and we have no regression means, that we have to do private validation and PPD validation campaign. This PR may be merged to special branches GEANT4 and G4VECGEOM.

@mrodozov mrodozov merged commit 39d5606 into IB/CMSSW_12_0_X/geant4 Jun 20, 2021
@smuzaffar smuzaffar deleted the g4-1072-novecgeom branch June 25, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants