Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report each RelVal failure once; fix formatting #2382

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

iarspider
Copy link
Contributor

Example of broken formatting:

image

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

@smuzaffar this reports first error found (i.e. first line containing ERROR executing), or DAS_ERROR. Let me know if that's not the right approach.

@cmsbuild
Copy link
Contributor

Pull request #2382 was updated.

@smuzaffar
Copy link
Contributor

please test

looks good though

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de0dce/43062/summary.html
COMMIT: d99f08c
CMSSW: CMSSW_15_0_X_2024-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2382/43062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

please test workflow 11834.0,11834.13

lets test some workflow which are failing in IBs

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de0dce/43069/summary.html
COMMIT: d99f08c
CMSSW: CMSSW_15_0_X_2024-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2382/43069/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 25-Nov-2024 18:59:52 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 25-Nov-2024 18:59:48 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit c846de0 into master Nov 25, 2024
10 of 11 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the fix-pr-relval-report branch November 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants