Fix and improve setup of alpaka tiles #38

sbaldu · 2024-04-08T12:32:22Z

This PR:

reworks the setup of the tiles using an alpaka buffer
supports a larger number of points

CLUEstering/alpaka/DataFormats/alpaka/TilesAlpaka.h

CLUEstering/alpaka/CLUE/CLUEAlgoAlpaka.h

sbaldu requested a review from waredjeb April 9, 2024 13:58

sbaldu commented Apr 9, 2024

View reviewed changes

CLUEstering/alpaka/DataFormats/alpaka/TilesAlpaka.h Outdated Show resolved Hide resolved

sbaldu added 17 commits April 12, 2024 10:53

Add overload of resizeTiles

ee8de58

Update type

6a835ce

Setup temporary Tiles using host_buffer

3df2a6e

Formatting

4b52ac8

Set TilesAlpaka constructor as default

37b6898

Delete old overload of resizeTiles

af27522

Update to version 2.2.1

933ced1

Fix parameters in __main__

4155f8d

Change parameters in test

bc3b8e4

Rework members of TilesAlpaka as private

4c74162

Inline new methods

8430d74

Fix typo

75c7bcb

Add resize of tiles outer VecArray

c66766b

Change default values for tile number and depths

0ee66e8

Formatting

61f4023

Use pointsPerTile when calculating tile number

34b4642

Set default ppbin to 128

b44da4e

sbaldu force-pushed the fix_alpakatiles_setup branch from e354d62 to b44da4e Compare April 12, 2024 08:54

sbaldu marked this pull request as draft April 15, 2024 06:26

sbaldu added 9 commits April 22, 2024 15:46

Add non-const data() to VecArray

f28e76e

Update TilesAlpaka

c07a4b5

Add KernelResetTiles

312b63f

Setup Tiles directly on device

09ccdf9

Add overload of resizeTiles

720ab69

Update type

f6b8176

Setup temporary Tiles using host_buffer

d9f177d

Formatting

6ba74d5

Set TilesAlpaka constructor as default

1b97754

sbaldu added 9 commits April 22, 2024 15:53

Change parameters in test

490827e

Rework members of TilesAlpaka as private

fc756d7

Inline new methods

40d2176

Fix typo

0d8e470

Add resize of tiles outer VecArray

b86f994

Change default values for tile number and depths

317fa23

Formatting

253becf

Use pointsPerTile when calculating tile number

07efc80

Set default ppbin to 128

f7fc294

sbaldu force-pushed the fix_alpakatiles_setup branch from b44da4e to f7fc294 Compare April 22, 2024 13:53

sbaldu added 8 commits April 22, 2024 15:55

Merge branch 'fix_alpakatiles_setup_ondevice' into fix_alpakatiles_setup

b66e73f

Fix typo

d411d92

Set tile size on device manually

74bfd55

Define CoordinateExtremes class

be94528

Update min_max and tile_size

9152714

Update setup of tiles

2b7a3cf

Make min_max and tile_size private

e2d9e72

Remove comments

0ec2c0a

sbaldu marked this pull request as ready for review May 7, 2024 08:47

sbaldu added 5 commits July 6, 2024 23:21

Add test for multiple backends results

d86155e

Rename method

b99d390

Fix typos and lint

766397f

Fix typo

a38da37

Merge branch 'test_multiple_backends' into fix_alpakatiles_setup

8aad904

waredjeb requested changes Jul 18, 2024

View reviewed changes

CLUEstering/alpaka/CLUE/CLUEAlgoAlpaka.h Outdated Show resolved Hide resolved

CLUEstering/alpaka/CLUE/CLUEAlgoAlpaka.h Outdated Show resolved Hide resolved

sbaldu added 3 commits July 18, 2024 16:05

Remove unneeded alpaka wait

3f2e505

Merge branch 'main' into fix_alpakatiles_setup

af4da81

Update version

16b565a

sbaldu merged commit 9dac229 into cms-patatrack:main Jul 23, 2024
20 of 23 checks passed

sbaldu deleted the fix_alpakatiles_setup branch September 29, 2024 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and improve setup of alpaka tiles #38

Fix and improve setup of alpaka tiles #38

sbaldu commented Apr 8, 2024

Fix and improve setup of alpaka tiles #38

Fix and improve setup of alpaka tiles #38

Conversation

sbaldu commented Apr 8, 2024