Add L1Nano compatibility and first configs for 14x release validation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,13 @@ def _transform_key(self, raw_key: str, obj: str): | |||
| NTuple branch names for quality and region | |||
| to "quality"/"region". | |||
| """ | |||
| key = raw_key.removeprefix(obj).lower() | |||
| ## nano | |||
| if ("_" in raw_key) and ("dr_0" not in raw_key): | |||
There was a problem hiding this comment.
In theory this could be dr_1 as well https://github.com/cms-l1-dpg/Phase2-L1MenuTools/blob/0ca5cf27473788010c3186ab42384382ded5d994/menu_tools/caching/cache_objects.py#L25C9-L25C64
| @@ -63,7 +63,12 @@ def get_branches(ntuple_path: str, tree: str, obj: str): | |||
| else: | |||
| prefix = "L1PhaseII/" | |||
|
|
|||
| obj_branches = [x.removeprefix(prefix + obj) for x in all_branches if obj in x] | |||
| ## nano | |||
There was a problem hiding this comment.
I would leave the indentation level as before (i.e. not put this code in the with block) as there is no operation here anymore requiring the file to be opened.
…ano, add matching eff vs eta for taus
Tau-Jet-MET updates
|
Superseded by #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_in the branch names -> added some exceptions for backward compatibility with the menu ntuples