Make Device.update_state and Device.push_state_update wait for a reply from the AC #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the `Device.update_state` wait for the properties to actually be updated before returning. The wait time is limited by the `wait_for` parameter (which was previously present, but not used). This way, when `Device.update_state` returns, properties are guaranteed to be updated. This commit also fixes a few tests, which appear to have had some bugs.
…se from the AC This change makes the `Device.push_state_update` wait for the a response from the AC to be received before returning. The wait time is limited by the `wait_for` parameter (which was previously present, but not used). This way callers of `Device.push_state_update` can be sure that their request reached the AC when the method returns.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 95.75% 96.08% +0.32%
==========================================
Files 8 8
Lines 730 740 +10
==========================================
+ Hits 699 711 +12
+ Misses 31 29 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Device.update_stateandDevice.push_state_updatemethods previously sent requests to the remote device without awaiting a response, leaving the caller unable to verify whether the operation was successfully received and confirmed.This PR modifies that behavior. Both methods now wait for a response from the device before returning.
Additionally, although both methods already accepted a
wait_forparameter, but it was ignored. This parameter is now used as the timeout for receiving the response. If no response is received within the specified time, an exception is raised.