This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
Addition of sorting and filter options #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalHonegger
force-pushed
the
master
branch
from
c0c3ebc to
25c9d3c
Compare
|
I've just stumbled upon your PR and noticed that you're trying to get my fork merged back here ;) |
This means null & undefined will be displayed at the top when sorting ascendingly. This is in line with the sort order of empty strings. This behaviour can be changed by providing a custom sortBy function.
added if function check before sortBy execution
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.3. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.2.2...4.2.3) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…cket.io-parser-4.2.3 Bump socket.io-parser from 4.2.2 to 4.2.3
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…rd-wrap-1.2.5 Bump word-wrap from 1.2.3 to 1.2.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is a request to ask you to add sorting and filter options with your next update. I tried using this code: https://stackoverflow.com/questions/40678206/angular-2-filter-search-list with your table but it wasn't working. If you could please integrate the sorting and filter options that would be great.
Cheers.