Merge pull request #15 from cm45t3r/fix/hammers

fix(candlestick): Fix hammer functions.
cm45t3r · Mar 31, 2024 · 5cb30fb · 5cb30fb
2 parents 4fee63a + ccdf7e9
commit 5cb30fb
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -21,4 +21,8 @@
 * Add bullish and bearish hammers (inverted and non-inverted).
 * Add optional `ratio` param to hammers.
 * Fix kickers to exclude hammers.
-* Fix candle wrapping on engulfings.
+* Fix candle wrapping on engulfings.
+
+# 0.0.6 / 2024-03-31
+* Remove optional param `ratio` from hammer functions causing bad results.
+* Fix `bullishHammer`, `bearishHammer`, `bullishInvertedHammer`, `bearishInvertedHammer`, and `hangingMan` functions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "candlestick",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "description": "JavaScript library for candlestick patterns detection.",
   "homepage": "https://github.com/cm45t3r/candlestick",
   "author": {

diff --git a/src/candlestick.js b/src/candlestick.js
@@ -147,11 +147,10 @@ function findPattern(dataArray, callback) {
  * 
  * @param {Object} candlestick - object with fields 
  *   `{ open: number, high: number, low: number, close: number }`
- * @param {number} ratio - minimum `tail:body` ratio on a hammer.
  * @return {boolean} a boolean.
  */
- function isHammer(candlestick, ratio = 2) {
-  return tailLen(candlestick) > (bodyLen(candlestick) * ratio) &&
+ function isHammer(candlestick) {
+  return tailLen(candlestick) > (bodyLen(candlestick) * 2) &&
     wickLen(candlestick) < bodyLen(candlestick);
 }
 
@@ -161,11 +160,10 @@ function findPattern(dataArray, callback) {
  * 
  * @param {Object} candlestick - object with fields 
  *   `{ open: number, high: number, low: number, close: number }`
- * @param {number} ratio - minimum `tail:body` ratio on a hammer.
  * @return {boolean} a boolean.
  */
-function isInvertedHammer(candlestick, ratio = 2) {
-  return wickLen(candlestick) > (bodyLen(candlestick) * ratio) &&
+function isInvertedHammer(candlestick) {
+  return wickLen(candlestick) > (bodyLen(candlestick) * 2) &&
     tailLen(candlestick) < bodyLen(candlestick);
 }
 
@@ -376,7 +374,7 @@ function invertedHammer(dataArray) {
  * @return {Array} array of matches.
  */
  function bullishHammer(dataArray) {
-  return findPattern(dataArray, isHammer);
+  return findPattern(dataArray, isBullishHammer);
 }
 
 /**
@@ -387,7 +385,7 @@ function invertedHammer(dataArray) {
  * @return {Array} array of matches.
  */
  function bearishHammer(dataArray) {
-  return findPattern(dataArray, isHammer);
+  return findPattern(dataArray, isBearishHammer);
 }
 
 /**
@@ -398,7 +396,7 @@ function invertedHammer(dataArray) {
  * @return {Array} array of matches.
  */
  function bullishInvertedHammer(dataArray) {
-  return findPattern(dataArray, isHammer);
+  return findPattern(dataArray, isBullishInvertedHammer);
 }
 
 /**
@@ -409,7 +407,7 @@ function invertedHammer(dataArray) {
  * @return {Array} array of matches.
  */
  function bearishInvertedHammer(dataArray) {
-  return findPattern(dataArray, isHammer);
+  return findPattern(dataArray, isBearishInvertedHammer);
 }
 
 /**
@@ -420,7 +418,7 @@ function invertedHammer(dataArray) {
  * @return {Array} array of matches.
  */
 function hangingMan(dataArray) {
-  return findPattern(dataArray, isShootingStar);
+  return findPattern(dataArray, isHangingMan);
 }
 
 /**