Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added license details to dataset object. This is required for migrati… #455

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Added license details to dataset object. This is required for migrati… #455

wants to merge 3 commits into from

Conversation

ddey2
Copy link
Member

@ddey2 ddey2 commented Aug 30, 2024 •
edited
Loading

…ng licenses to v2.

Description

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ddey2 ddey2 mentioned this pull request Aug 30, 2024
Merged
longshuicy
longshuicy reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without testing, the code looks good.
Could you add an entry in the changelog?

@ddey2
Copy link
Member Author

ddey2 commented Aug 30, 2024

Without testing, the code looks good. Could you add an entry in the changelog?

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshuicy longshuicy longshuicy left review comments

@lmarini lmarini Awaiting requested review from lmarini

@tcnichol tcnichol Awaiting requested review from tcnichol

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddey2 @longshuicy