Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding creator to space json returned, adding route for users in space #453

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

adding creator to space json returned, adding route for users in space #453

wants to merge 3 commits into from

Conversation

tcnichol
Copy link
Contributor

Currently the space json does not include the creator for the api routes. I have added it since this will be needed for migrating spaces.

@tcnichol tcnichol linked an issue Aug 23, 2024 that may be closed by this pull request
add creator to json returned by space api endpoints #452
Open
@tcnichol tcnichol requested review from lmarini and longshuicy August 23, 2024 18:59
@tcnichol tcnichol marked this pull request as draft August 23, 2024 19:48
@tcnichol tcnichol changed the title adding creator to the space json returned adding creator to space json returned, adding route for users in space Aug 23, 2024
@tcnichol tcnichol marked this pull request as ready for review August 23, 2024 20:11
@tcnichol tcnichol mentioned this pull request Aug 26, 2024
Open
6 tasks
longshuicy
longshuicy requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I haven't got time to test it.
One thing I noticed, you probably also need to add an entry on Changelog.

app/api/Spaces.scala Show resolved Hide resolved
app/api/Spaces.scala Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshuicy longshuicy longshuicy requested changes

@lmarini lmarini Awaiting requested review from lmarini

@max-zilla max-zilla Awaiting requested review from max-zilla

@robkooper robkooper Awaiting requested review from robkooper

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add creator to json returned by space api endpoints
2 participants
@tcnichol @longshuicy