add readonly mode #406
Merged
add readonly mode #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested with create spaces/datasets/files but might be missing special cases. fixes #405
|
tested this, was able to create a dataset using Create Dataset button on the explore page when logged in as user with status set to ReadOnly ( |
max-zilla
requested changes
Mar 31, 2023
lmarini
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Found a few more links in a couple of places:
- Dashboard at the top Create Space / Dataset Collection
- Dashboard My Spaces tab and My Collection tab
- Profile page, Spaces and Collections tabs (might be same template as dashboard)
- Selections, Delete All / Tag all
Left two other comments inline.
app/api/ApiController.scala
Outdated
| case Some(resource) if Permission.checkOwner(u, resource) => block(userRequest) | ||
| case _ => Future.successful(Unauthorized("Not authorized")) | ||
| } | ||
| if(u.status == UserStatus.ReadOnly && !api.Permission.READONLY.contains(permission)) { |
There was a problem hiding this comment.
I think we need to add this logic to controllers.SecuredController.PermissionAction to lock pages like /datasets/new
lmarini
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with create spaces/datasets/files but might be missing special cases. fixes #405
Description
A request was made to be able to mark users as read-only. They should not be able to create new spaces, or anything else. All they can do is view things.
Use 2 users, an admin user and set the second user to readonly
See if the readonly user can do any write operations, create spaces/datasets/collections/files/tags/comments etc.
Review Time Estimate
Types of changes
Checklist: