Added Google's model viewer within viewer_three.js #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chrysovalantis Constantinou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi! To test the changes please use the attached file containing 3D models :) |
robkooper
reviewed
Aug 26, 2022
cconsta1
commented
Aug 27, 2022
lmarini
requested changes
Aug 29, 2022
|
Hi Luigi,
Maybe this has something to do with the fact that I now used Google’s model viewer to load the GLB files instead of the three.js library (which I used before). But no it’s not intentional. I can check tomorrow. However, I did notice the viewport getting huge, which happens when I load 3D models with the developer tools open. I don’t know why that happens to be honest. To reproduce this, please load a file with the tools open and once it loads close the dev tools.
Best regards,
Valentino
…Sent from my iPhone
On Aug 29, 2022, at 11:48 PM, Luigi Marini ***@***.***> wrote:
@lmarini requested changes on this pull request.
I noticed that when viewing .glb files the viewerport is much smaller than when viewing .fbx. Is that intentional?
Testing on firefox and chrome on mac.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
@cconsta1 I tried with developer tools open on both firefox and chrome but the same thing happens. |
|
Hi Luigi,
I think I know what the problem might be. The GLB file loads using the
element <model-viewer>. On my first try, the viewport was as small as yours
in the picture but I remedied that by adding a CSS entry:
model-viewer {
width: 640px;
height: 480px;
}
The CSS file (style.css) loads inside the viewer_three.js file. Somehow,
it's not working on your side. I can check tomorrow. I'm attaching what I'm
seeing on my side.
Regards,
Valentino
On Tue, Aug 30, 2022 at 1:00 AM Luigi Marini ***@***.***>
wrote:
… Hi Luigi, Maybe this has something to do with the fact that I now used
Google’s model viewer to load the GLB files instead of the three.js library
(which I used before). But no it’s not intentional. I can check tomorrow.
However, I did notice the viewport getting huge, which happens when I load
3D models with the developer tools open. I don’t know why that happens to
be honest. To reproduce this, please load a file with the tools open and
once it loads close the dev tools. Best regards, Valentino
… <#m_-7621028661472024347_>
Sent from my iPhone
On Aug 29, 2022, at 11:48 PM, Luigi Marini *@*.***> wrote: @lmarini
<https://github.com/lmarini> requested changes on this pull request. I
noticed that when viewing .glb files the viewerport is much smaller than
when viewing .fbx. Is that intentional? Testing on firefox and chrome on
mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You
are receiving this because you authored the thread.
@cconsta1 <https://github.com/cconsta1> I tried with developer tools open
on both firefox and chrome but the same thing happens.
—
Reply to this email directly, view it on GitHub
<#372 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you, Valentino. So you have the same problem, but adding the model-viewer style at run time fixes it? Do you always have to add it after you refresh the page?
Thank you,
Luigi
From: Chrysovalantis Constantinou ***@***.***>
Date: Monday, August 29, 2022 at 5:17 PM
To: clowder-framework/clowder ***@***.***>
Cc: Marini, Luigi ***@***.***>, Mention ***@***.***>
Subject: Re: [clowder-framework/clowder] Added Google's model viewer within viewer_three.js (PR #372)
Hi Luigi,
I think I know what the problem might be. The GLB file loads using the
element <model-viewer>. On my first try, the viewport was as small as yours
in the picture but I remedied that by adding a CSS entry:
model-viewer {
width: 640px;
height: 480px;
}
The CSS file (style.css) loads inside the viewer_three.js file. Somehow,
it's not working on your side. I can check tomorrow. I'm attaching what I'm
seeing on my side.
Regards,
Valentino
On Tue, Aug 30, 2022 at 1:00 AM Luigi Marini ***@***.***>
wrote:
Hi Luigi, Maybe this has something to do with the fact that I now used
Google’s model viewer to load the GLB files instead of the three.js library
(which I used before). But no it’s not intentional. I can check tomorrow.
However, I did notice the viewport getting huge, which happens when I load
3D models with the developer tools open. I don’t know why that happens to
be honest. To reproduce this, please load a file with the tools open and
once it loads close the dev tools. Best regards, Valentino
… <#m_-7621028661472024347_>
Sent from my iPhone
On Aug 29, 2022, at 11:48 PM, Luigi Marini *@*.***> wrote: @lmarini
<https://github.com/lmarini><https://urldefense.com/v3/__https:/github.com/lmarini*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDKxwJz6Uw$> requested changes on this pull request. I
noticed that when viewing .glb files the viewerport is much smaller than
when viewing .fbx. Is that intentional? Testing on firefox and chrome on
mac. — Reply to this email directly, view it on GitHub, or unsubscribe. You
are receiving this because you authored the thread.
@cconsta1 <https://github.com/cconsta1><https://urldefense.com/v3/__https:/github.com/cconsta1*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDKy_kXjYA$> I tried with developer tools open
on both firefox and chrome but the same thing happens.
—
Reply to this email directly, view it on GitHub
<#372 (comment)><https://urldefense.com/v3/__https:/github.com/clowder-framework/clowder/pull/372*issuecomment-1230907876*3E__;IyU!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDIDdxqp5w$>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA><https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJ3IKS7FPYYDECD5GT4DOH3V3UXJNANCNFSM56ODJLIA*3E__;JQ!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDI1UqVq3g$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/clowder-framework/clowder/pull/372*issuecomment-1230926749__;Iw!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDJUPfQwcQ$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAESNLJNFJK6UEX6SBM6HD3V3UZI5ANCNFSM56ODJLIA__;!!DZ3fjg!5bEmi9TDZ7MxLva6Ak3GtRPsz7F-u1uKHY7wkO-FN9LZuRc4pTI6xd8kehUhOtdsUJGWzA079UwntnxNwDIMAOdu0w$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi! I think I never answered this! What do you mean by loading the CSS style at run time? |
lmarini
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review Time Estimate
Types of changes
Checklist: