feat: more logs

[dinhani-cw]

No description provided.

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve only log message updates and a comment change. The PR is small and the logic remains unchanged, making it relatively easy to review.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

Code feedback:

---

relevant file	src/eth/storage/inmemory/inmemory_temporary.rs
suggestion	Consider adding more detailed context to the log message for better traceability. For example, include initialization parameters or state if applicable. [medium]
relevant line	tracing::info!("creating inmemory temporary storage");

---

relevant file	src/eth/storage/rocks/rocks_permanent.rs
suggestion	It might be beneficial to handle potential errors from state.sync_data().await before proceeding with other operations to ensure the storage state is ready and consistent. [important]
relevant line	tracing::info!("creating rocksdb storage");

---

relevant file	src/infra/blockchain_client/blockchain_client.rs
suggestion	Since the method name was changed to fetch_block_number, consider updating the log message to reflect this new terminology consistently throughout the method's implementation. [medium]
relevant line	/// Fetches the current block number.

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Improve the log message for clarity and specificity Consider using a more descriptive log message for the creation of in-memory temporary storage. The current message does not specify what is being created or its purpose. src/eth/storage/inmemory/inmemory_temporary.rs [55] -tracing::info!("creating inmemory temporary storage"); +tracing::info!("Initializing new InMemoryTemporaryStorage instance to manage temporary states in memory."); Suggestion importance[1-10]: 8 Why: The suggestion improves the clarity and specificity of the log message, making it more informative about what is being created and its purpose. This enhances the readability and maintainability of the code.	8
	Enhance the log message to provide more detailed context about the RocksDB storage initialization Update the log message to include more details about the RocksDB storage initialization, such as the configuration or the expected operations. src/eth/storage/rocks/rocks_permanent.rs [43] -tracing::info!("creating rocksdb storage"); +tracing::info!("Creating new RocksDB storage instance with default configuration for persistent data management."); Suggestion importance[1-10]: 8 Why: The suggested log message provides more context about the initialization process, including the configuration and purpose of the RocksDB storage. This makes the logs more useful for debugging and understanding the system's behavior.	8
Maintainability	Update the log message to match the updated method name and provide more clarity The method name and the documentation comment have been updated to 'fetch_block_number' but the log message still uses 'fetching block number'. It would be more consistent to update the log message to reflect the new method name for clarity. src/infra/blockchain_client/blockchain_client.rs [129] -tracing::debug!("fetching block number"); +tracing::debug!("Fetching the current block number from the blockchain."); Suggestion importance[1-10]: 7 Why: The suggestion improves consistency between the method name, documentation comment, and log message. This enhances code readability and maintainability, although the improvement is relatively minor.	7