Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce clock test duration #901

Merged
merged 1 commit into from
May 22, 2024
Merged

reduce clock test duration #901

merged 1 commit into from
May 22, 2024

Conversation

gabriel-aranha-cw
Copy link
Contributor

Reducing duration from 180 to 120 seconds

@gabriel-aranha-cw gabriel-aranha-cw requested a review from a team as a code owner May 22, 2024 20:55
@gabriel-aranha-cw gabriel-aranha-cw enabled auto-merge (squash) May 22, 2024 20:55
Copy link

PR Review 🔍

⏱️ Estimated effort to review [1-5]

1, because the PR involves a simple change in a single variable value within a shell script. The change is straightforward and does not involve complex logic or multiple files.

🧪 Relevant tests

No

⚡ Possible issues

No

🔒 Security concerns

No

Code feedback:

Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Enhancement
Make the sleep interval configurable to enhance flexibility

Consider reducing the sleep interval further or making it configurable via an environment
variable or script parameter. This change would allow more flexibility in adjusting the
interval based on different environments or requirements without modifying the script.

utils/block-time-check.sh [5]

-sleep_interval=120
+sleep_interval=${SLEEP_INTERVAL:-120}
 
Suggestion importance[1-10]: 9

Why: Making the sleep interval configurable via an environment variable or script parameter is a valuable enhancement. It increases the script's flexibility and adaptability to different environments without requiring direct modifications to the script.

9

@gabriel-aranha-cw gabriel-aranha-cw merged commit c12dd9c into main May 22, 2024
27 checks passed
@gabriel-aranha-cw gabriel-aranha-cw deleted the adjust-clock-duration branch May 22, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants