feat: external relayer (part 1)

[carneiro-cw]

WIP

[carneiro-cw]

I will merge this PR since it is starting to conflict too much, and I will resume work on the relayer on a new PR

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	4, because the PR introduces significant changes across multiple files including Rust and SQL, affecting core functionalities such as transaction relaying and mining. The complexity of the changes, especially with the introduction of external relayers and modifications to the mining configuration, requires careful review to ensure correctness and maintainability.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The new ExternalRelayer and ExternalRelayerClient classes are introduced without accompanying unit tests. This could lead to undetected bugs in relaying logic.
	Performance Concern: The relay_next_block function in ExternalRelayer uses a SQL query that might not scale well with a large number of unrelayed blocks due to its subquery for the minimum block number.
🔒 Security concerns	No

Code feedback:

---

relevant file	src/eth/relayer/external.rs
suggestion	Consider implementing retry logic with exponential backoff for the relay_next_block method to handle transient failures in block relaying. This will enhance the robustness of the relaying process. [important]
relevant line	pub async fn relay_next_block(&self) -> anyhow::Result> {

---

relevant file	src/eth/relayer/external.rs
suggestion	Add detailed logging for each step in the relay_dag function to improve traceability and debugging of the transaction relaying process. [important]
relevant line	async fn relay_dag(&self, mut dag: TransactionDag) -> anyhow::Result<()> {

---

relevant file	src/eth/block_miner.rs
suggestion	Ensure error handling for relayer.send_to_relayer(block.clone()).await?; to manage scenarios where the relayer service might be down or unresponsive. Consider a fallback mechanism or queuing system. [important]
relevant line	relayer.send_to_relayer(block.clone()).await?;

---

relevant file	src/config.rs
suggestion	Validate configurations for ExternalRelayerClientConfig and ExternalRelayerServerConfig during startup to ensure all required parameters are provided and valid. This prevents runtime errors due to misconfiguration. [medium]
relevant line	pub struct ExternalRelayerClientConfig {

---

[github-actions]

Failed to generate code suggestions for PR