Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: build fail fast #516

Merged
merged 1 commit into from
Apr 3, 2024
Merged

test: build fail fast #516

merged 1 commit into from
Apr 3, 2024

Conversation

mayconamaroCW
Copy link
Contributor

@mayconamaroCW mayconamaroCW commented Apr 3, 2024 •
edited
Loading

Introduces the build step before dispatching stratus run in background

  • If the build fails, the entire action will now abort instead of hanging in wait-service
  • wait-service timeout now applies only to run step, and the default timeout can be dramatically reduced
  • refactor flags to ensure debug and release only differ in --release flag.

Tests

  • Happy path not affected
  • Compilation error abort

@mayconamaroCW mayconamaroCW requested a review from a team as a code owner April 3, 2024 16:51
@mayconamaroCW mayconamaroCW force-pushed the test/fail-fast-build branch from 0f02ab6 to 712c325 Compare April 3, 2024 17:09
@mayconamaroCW mayconamaroCW enabled auto-merge (squash) April 3, 2024 17:11
@mayconamaroCW mayconamaroCW disabled auto-merge April 3, 2024 17:11
@mayconamaroCW mayconamaroCW enabled auto-merge (squash) April 3, 2024 17:12
@mayconamaroCW mayconamaroCW merged commit 6c5ef83 into main Apr 3, 2024
48 checks passed
@mayconamaroCW mayconamaroCW deleted the test/fail-fast-build branch April 3, 2024 17:16
@mayconamaroCW mayconamaroCW linked an issue Apr 3, 2024 that may be closed by this pull request
[CI] Improve error management #502
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Improve error management
1 participant
@mayconamaroCW