Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused deps #1918

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: remove unused deps #1918

merged 1 commit into from
Dec 13, 2024

Conversation

carneiro-cw
Copy link
Contributor

@carneiro-cw carneiro-cw commented Dec 13, 2024

PR Type

Enhancement


Description

  • Removed the 'openssl' dependency with its 'vendored' feature
  • Cleaned up dev dependencies by removing:
    • 'binary_macros'
    • 'fancy-duration'
    • 'stringreader'
  • These changes help streamline the project's dependencies, potentially reducing build times and minimizing potential security vulnerabilities

Changes walkthrough 📝

Relevant files
Dependencies
Cargo.toml
Remove unused dependencies from Cargo.toml                             

Cargo.toml

  • Removed unused dependency 'openssl'
  • Removed unused dev dependencies: 'binary_macros', 'fancy-duration',
    and 'stringreader'
  • +0/-4     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Removal
    Verify that the removal of 'openssl', 'binary_macros', 'fancy-duration', and 'stringreader' dependencies does not break any existing functionality or tests in the project.

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @carneiro-cw carneiro-cw enabled auto-merge (squash) December 13, 2024 16:19
    @carneiro-cw carneiro-cw disabled auto-merge December 13, 2024 16:19
    @carneiro-cw carneiro-cw enabled auto-merge (squash) December 13, 2024 16:19
    @carneiro-cw carneiro-cw merged commit c42f360 into main Dec 13, 2024
    34 checks passed
    @carneiro-cw carneiro-cw deleted the remove_unused_deps branch December 13, 2024 16:34
    @gabriel-aranha-cw
    Copy link
    Contributor

    Final benchmark:
    Run ID: bench-3812173285

    Git Info:

    Configuration:

    • Target Account Strategy: Default

    RPS Stats: Max: 1079.00, Min: 517.00, Avg: 947.00, StdDev: 66.81
    TPS Stats: Max: 1090.00, Min: 780.00, Avg: 919.17, StdDev: 69.41

    Plot: View Plot

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants