Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove manual serialization #1915

Merged
merged 3 commits into from
Dec 12, 2024
Merged

chore: remove manual serialization #1915

merged 3 commits into from
Dec 12, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Dec 12, 2024

PR Type

Enhancement


Description

  • Automatically derived Serialize for AccountTransferDirection enum with #[serde(rename_all = "snake_case")] to serialize variants as "credit" and "debit".

@carneiro-cw
Copy link
Contributor

Thanks for your PR! Please run just lint to ensure your code passes our lint checks.

@mvares
Copy link
Contributor Author

mvares commented Dec 12, 2024

@carneiro-cw feel free to check out my PR now.

Copy link
Contributor

@carneiro-cw carneiro-cw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carneiro-cw carneiro-cw merged commit ffbc3da into cloudwalk:main Dec 12, 2024
34 checks passed
@gabriel-aranha-cw
Copy link
Contributor

Final benchmark:
Run ID: bench-917946050

Git Info:

Configuration:

  • Target Account Strategy: Default

RPS Stats: Max: 1153.00, Min: 705.00, Avg: 978.78, StdDev: 60.33
TPS Stats: Max: 1092.00, Min: 821.00, Avg: 948.75, StdDev: 62.46

Plot: View Plot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants