enha: use faster library for storage cache

[marcospb19-cw]

PR Type

Enhancement

---

Description

• Replaced LruCache with quick_cache::sync::Cache for improved performance in storage caching
• Removed Mutex locks, simplifying the code and potentially reducing contention
• Eliminated SmallVec usage, streamlining batch operations
• Updated dependencies: removed lru, added quick_cache
• Simplified cache operations (insert, get, clear) for better readability and maintenance
• Potential performance improvements due to the use of a more efficient caching library

---

Changes walkthrough 📝

	Relevant files
Enhancement	cache.rs Optimize storage cache implementation                                        src/eth/storage/cache.rs Replaced LruCache with quick_cache::sync::Cache Removed Mutex locks and parking_lot dependency Simplified cache operations (insert, get, clear) Removed SmallVec for batch operations +14/-33
Dependencies	Cargo.toml Update dependencies for new cache library                                Cargo.toml Removed lru dependency Added quick_cache dependency version 0.6.9 +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Performance Concern The new implementation uses fixed-size caches (100,000 for slots and 20,000 for accounts). Validate if these sizes are appropriate for the expected workload and if they might lead to frequent cache evictions. Error Handling The new implementation doesn't use expect for potential errors, which might make debugging more difficult if issues arise. Consider adding appropriate error handling or explanatory comments. Tracing The cache operations (insert, get, clear) are not instrumented with tracing events. Consider adding tracing to monitor cache performance and usage patterns.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	Implement error handling for cache operations to improve robustness Consider adding error handling or logging for potential cache insertion failures, as the quick_cache library's insert method may fail silently if the cache is full. src/eth/storage/cache.rs [33-35] pub fn cache_slot(&self, address: Address, slot: Slot) { - self.slot_cache.insert((address, slot.index), slot.value); + if !self.slot_cache.insert((address, slot.index), slot.value) { + // Log or handle the case where insertion fails + log::warn!("Failed to insert slot into cache: cache full"); + } } Suggestion importance[1-10]: 5 Why: The suggestion to add error handling for cache insertions is valid and could improve the robustness of the code. However, it's a minor improvement as the default behavior of quick_cache is likely sufficient for most use cases.	5

[marcospb19-cw]

/benchmark --target-account-strategy=partial0.33

[gabriel-aranha-cw]

Benchmark:
Run ID: bench-684589687

Git Info:

• Branch: enha-use-faster-cache-library-for-storage-cache
• Commit: 7021e5d
• PR: enha: use faster library for storage cache #1895

Configuration:

• Target Account Strategy: Override (Partial(0.33))

RPS Stats: Max: 1342.00, Min: 643.00, Avg: 1170.64, StdDev: 67.76
TPS Stats: Max: 1333.00, Min: 1012.00, Avg: 1135.74, StdDev: 73.22

Plot: View Plot

[marcospb19-cw]

/benchmark --target-account-strategy=partial0.5

[gabriel-aranha-cw]

Benchmark:
Run ID: bench-2722894004

Git Info:

• Branch: enha-use-faster-cache-library-for-storage-cache
• Commit: 7021e5d
• PR: enha: use faster library for storage cache #1895

Configuration:

• Target Account Strategy: Override (Partial(0.5))

RPS Stats: Max: 1378.00, Min: 973.00, Avg: 1247.69, StdDev: 57.76
TPS Stats: Max: 1396.00, Min: 1014.00, Avg: 1210.19, StdDev: 69.68

Plot: View Plot

[marcospb19-cw]

/benchmark --target-account-strategy=partial0.5

[gabriel-aranha-cw]

Benchmark:
Run ID: bench-4116690297

Git Info:

• Branch: enha-use-faster-cache-library-for-storage-cache
• Commit: 7021e5d
• PR: enha: use faster library for storage cache #1895

Configuration:

• Target Account Strategy: Override (Partial(0.5))

RPS Stats: Max: 1358.00, Min: 619.00, Avg: 1222.47, StdDev: 66.12
TPS Stats: Max: 1359.00, Min: 1021.00, Avg: 1186.43, StdDev: 66.50

Plot: View Plot

[gabriel-aranha-cw]

Final benchmark:
Run ID: bench-7709445

Git Info:

• Branch: main
• Commit: 7e09405
• PR: enha: use faster library for storage cache #1895

Configuration:

• Target Account Strategy: Default (Random)

RPS Stats: Max: 1288.00, Min: 554.00, Avg: 1120.67, StdDev: 76.11
TPS Stats: Max: 1267.00, Min: 943.00, Avg: 1087.99, StdDev: 77.32

Plot: View Plot