Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(e2e): remove commit hashes from contracts-remove.sh #1878

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mayconamaroCW
Copy link
Contributor

@mayconamaroCW mayconamaroCW commented Nov 22, 2024

PR Type

enhancement


Description

  • Removed hardcoded commit hashes from the remove function calls in the contracts-remove.sh script.
  • Simplified the script to make it more maintainable and less dependent on specific commit references.

Changes walkthrough 📝

Relevant files
Enhancement
contracts-remove.sh
Remove commit hashes from repository removal script           

e2e/cloudwalk-contracts/contracts-remove.sh

  • Removed commit hashes from remove function calls.
  • Simplified the script by eliminating hardcoded commit references.
  • +6/-6     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Control
    The removal of commit hashes might impact version control. Ensure that the script's functionality remains intact without these specific commit references.

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @mayconamaroCW mayconamaroCW merged commit c668abf into main Nov 22, 2024
    32 checks passed
    @mayconamaroCW mayconamaroCW deleted the refactor/remove-commit-script branch November 22, 2024 16:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant