perf: avoid recomputing tx_hash when saving execution

[dinhani-cw]

PR Type

Enhancement

---

Description

• Optimize save_execution method by computing tx_hash once at the beginning
• Update tracing span to use pre-computed tx_hash, reducing redundant computations
• Reorder operations in save_execution:
  • Notify about pending transactions before mining in automine mode
  • Improve code readability and potentially slight performance gain
• These changes aim to enhance performance by avoiding unnecessary recomputation of tx_hash

---

Changes walkthrough 📝

	Relevant files
Performance optimization	miner.rs Optimize transaction hash computation and execution flow  src/eth/miner/miner.rs Compute tx_hash once at the beginning of save_execution method Update tracing span to use pre-computed tx_hash Reorder operations: notify before mining in automine mode +6/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Performance Optimization The PR optimizes the save_execution method by computing tx_hash once at the beginning and reusing it. This change reduces redundant computations and potentially improves performance. Code Reordering The PR reorders operations in the save_execution method, notifying about pending transactions before mining in automine mode. This change improves code readability and potentially provides a slight performance gain.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Add error handling for the notification sending process Consider adding error handling for the send operation on self.notifier_pending_txs to ensure that the notification is properly sent or handled if it fails. src/eth/miner/miner.rs [113-114] // notify -let _ = self.notifier_pending_txs.send(tx_hash); +if let Err(e) = self.notifier_pending_txs.send(tx_hash) { + log::warn!("Failed to send notification for pending transaction: {:?}", e); +} Suggestion importance[1-10]: 7 Why: This suggestion adds important error handling, which can help with debugging and system stability.	7
Enhancement	Add debug logging for improved traceability in automine mode Consider adding a debug log statement before mining a block in automine mode to improve traceability and debugging capabilities. src/eth/miner/miner.rs [116-119] // if automine is enabled, automatically mines a block if self.mode.is_automine() { + log::debug!("Automine enabled, mining a new block"); self.mine_local_and_commit()?; } Suggestion importance[1-10]: 6 Why: This suggestion enhances debugging capabilities, which can be valuable for development and troubleshooting.	6
	Improve variable naming for better code readability and understanding of its purpose Consider using a more descriptive variable name for the transaction hash, such as tx_hash_for_notification, to clearly indicate its purpose in the notification process. src/eth/miner/miner.rs [97-101] -let tx_hash = tx_execution.hash(); +let tx_hash_for_notification = tx_execution.hash(); // track #[cfg(feature = "tracing")] -let _span = info_span!("miner::save_execution", %tx_hash).entered(); +let _span = info_span!("miner::save_execution", %tx_hash_for_notification).entered(); Suggestion importance[1-10]: 4 Why: The suggestion improves code readability slightly, but the current variable name 'tx_hash' is already clear and concise.	4
Maintainability	Add a comment to explain the purpose of a function parameter Consider adding a comment explaining why check_conflicts is passed as an argument to save_execution and what it does, to improve code maintainability. src/eth/miner/miner.rs [110-111] // save execution to temporary storage +// check_conflicts determines whether to verify transaction conflicts before saving self.storage.save_execution(tx_execution, check_conflicts)?; Suggestion importance[1-10]: 5 Why: The suggestion improves code documentation, which is beneficial for maintainability, but it's not addressing a critical issue.	5