refactor: remove unused mine_external_mixed from miner

[dinhani-cw]

PR Type

Enhancement

---

Description

• Removed unused mine_external_mixed() and mine_external_mixed_and_commit() methods from the Miner struct
• Updated the importer to use mine_external_and_commit() instead of mine_external_mixed_and_commit()
• Simplified the miner implementation by removing logic for mining external mixed blocks
• This change reduces code complexity and removes unused functionality

---

Changes walkthrough 📝

Relevant files

Enhancement

importer.rs Update miner method call in importer                                          src/eth/follower/importer/importer.rs Changed mine_external_mixed_and_commit() to mine_external_and_commit() +1/-1      miner.rs Remove unused external mixed mining methods                            src/eth/miner/miner.rs Removed mine_external_mixed_and_commit() method Removed mine_external_mixed() method Removed logic for mining external mixed blocks +0/-44

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Method Change The PR changes the method call from mine_external_mixed_and_commit() to mine_external_and_commit(). Ensure this change is consistent throughout the codebase and doesn't break any functionality.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Add logging for successful mining and committing of external blocks Consider adding error handling or logging for the case when mine_external_and_commit() succeeds. This will provide better visibility into the successful execution of the mining process. src/eth/follower/importer/importer.rs [192-195] -if let Err(e) = miner.mine_external_and_commit() { - let message = GlobalState::shutdown_from(TASK_NAME, "failed to mine external block"); - return log_and_err!(reason = e, message); +match miner.mine_external_and_commit() { + Ok(_) => tracing::info!("Successfully mined and committed external block"), + Err(e) => { + let message = GlobalState::shutdown_from(TASK_NAME, "failed to mine external block"); + return log_and_err!(reason = e, message); + } }; Suggestion importance[1-10]: 7 Why: The suggestion improves error handling and adds logging for successful cases, enhancing the code's observability and debugging capabilities.	7
Best practice	Use a more specific error type for better error handling and propagation Consider using a more specific error type instead of anyhow::Error for better error handling and propagation. This can help in distinguishing between different types of errors that might occur during the mining process. src/eth/follower/importer/importer.rs [192-195] if let Err(e) = miner.mine_external_and_commit() { let message = GlobalState::shutdown_from(TASK_NAME, "failed to mine external block"); - return log_and_err!(reason = e, message); + return log_and_err!(reason = MiningError::from(e), message); }; Suggestion importance[1-10]: 6 Why: Using a more specific error type can improve error handling, but it requires creating a new error type which may not be necessary if the current error handling is sufficient.	6