chore: solve warnings

[marcospb19-cw]

PR Type

enhancement

---

Description

• Added conditional compilation for metrics feature in multiple files.
• Removed unnecessary #[allow(dead_code)] attribute in rpc_context.rs.
• Added conditional attribute to allow unused variables when metrics feature is not enabled in rpc_middleware.rs.

---

Changes walkthrough 📝

Relevant files

Enhancement

executor.rs Add conditional compilation for metrics feature                    src/eth/executor/executor.rs Added conditional compilation for metrics feature. +1/-0      rpc_context.rs Remove unnecessary allow(dead_code) attribute                        src/eth/rpc/rpc_context.rs Removed unnecessary #[allow(dead_code)] attribute. +0/-1      rpc_middleware.rs Add conditional compilation and attribute for metrics feature src/eth/rpc/rpc_middleware.rs Added conditional compilation for metrics feature. Added conditional attribute to allow unused variables when metrics feature is not enabled. +3/-0      rocks_state.rs Add conditional compilation for metrics feature                    src/eth/storage/rocks/rocks_state.rs Added conditional compilation for metrics feature. +1/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Unused Variables The conditional attribute #[cfg_attr(not(feature = "metrics"), allow(unused_variables))] added on line 169 is a good practice to avoid warnings. However, ensure that this does not hide potential issues where variables should be used or removed entirely. Unwrap Usage The function db_path_filename on line 155 uses unwrap which can cause a panic if the value is None. Consider using expect with a meaningful error message to handle this case more gracefully.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Move the #[cfg(feature = "metrics")] attribute directly above the use statement to ensure conditional compilation To ensure that the codegen module is only included when the metrics feature is enabled, consider moving the #[cfg(feature = "metrics")] attribute directly above the use crate::eth::codegen; line. src/eth/executor/executor.rs [10-11] +#[cfg(feature = "metrics")] +use crate::eth::codegen; - Suggestion importance[1-10]: 10 Why: This suggestion ensures that the codegen module is only included when the metrics feature is enabled, which is a best practice for conditional compilation and avoids unnecessary code inclusion.	10
Possible issue	Use expect with descriptive error messages instead of unwrap to handle potential errors more gracefully To avoid potential runtime panics, consider handling the unwrap calls in db_path_filename method more gracefully by using expect with a descriptive error message. src/eth/storage/rocks/rocks_state.rs [156-157] -self.db.path().file_name().unwrap().to_str().unwrap() +self.db.path().file_name().expect("Failed to get file name").to_str().expect("Failed to convert to str") Suggestion importance[1-10]: 9 Why: Using expect with descriptive error messages instead of unwrap helps avoid potential runtime panics and provides more context if an error occurs, improving code robustness.	9
	Re-add the #[allow(dead_code)] attribute to the miner field to avoid potential warnings if it remains unused To maintain consistency and avoid potential future issues, consider adding the #[allow(dead_code)] attribute back to the miner field if it is still not being used. src/eth/rpc/rpc_context.rs [26] +#[allow(dead_code)] // HACK this was triggered in Rust 1.79 pub miner: Arc<Miner>, Suggestion importance[1-10]: 8 Why: Re-adding the #[allow(dead_code)] attribute prevents potential warnings if the miner field remains unused, maintaining code consistency and avoiding future issues.	8
Maintainability	Add a comment explaining the purpose of the #[cfg_attr] attribute for better readability To improve readability and maintainability, add a comment explaining why the #[cfg_attr(not(feature = "metrics"), allow(unused_variables))] attribute is necessary. src/eth/rpc/rpc_middleware.rs [169-170] +// Allow unused variables when metrics feature is disabled #[cfg_attr(not(feature = "metrics"), allow(unused_variables))] let (level, error_code) = match response_result Suggestion importance[1-10]: 7 Why: Adding a comment improves readability and maintainability by explaining why the #[cfg_attr] attribute is used, which is helpful for future developers.	7